<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:PMingLiU;
panose-1:2 2 5 0 0 0 0 0 0 0;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:PMingLiU;
panose-1:2 1 6 1 0 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 90.0pt 72.0pt 90.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal">Hi Matt,<o:p></o:p></p>
<p class="MsoNormal">I meet an issue in bmcweb while update service handle firmware update error<o:p></o:p></p>
<p class="MsoNormal"><a href="https://github.com/openbmc/bmcweb/blob/master/redfish-core/lib/update_service.hpp#L321">https://github.com/openbmc/bmcweb/blob/master/redfish-core/lib/update_service.hpp#L321</a>
<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">After I revert the change or try to change the match rule from 'PropertiesChanged' to 'InterfacesAdded',
<o:p></o:p></p>
<p class="MsoNormal">the error handler work well in update service.<o:p></o:p></p>
<p class="MsoNormal"> fwUpdateErrorMatcher = std::make_unique<sdbusplus::bus::match::match>(<o:p></o:p></p>
<p class="MsoNormal"> *crow::connections::systemBus,<o:p></o:p></p>
<p class="MsoNormal">- "type='signal',member='PropertiesChanged',path_namespace='/xyz/"<o:p></o:p></p>
<p class="MsoNormal">- "openbmc_project/logging/entry',"<o:p></o:p></p>
<p class="MsoNormal">- "arg0='xyz.openbmc_project.Logging.Entry'",<o:p></o:p></p>
<p class="MsoNormal">+ "interface='org.freedesktop.DBus.ObjectManager',type='signal',"<o:p></o:p></p>
<p class="MsoNormal">+ "member='InterfacesAdded',"<o:p></o:p></p>
<p class="MsoNormal">+ "path='/xyz/openbmc_project/logging'",<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">May I ask the reason why you update the change? <a href="https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-logging/+/46055">https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-logging/+/46055</a>
<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks<o:p></o:p></p>
<p class="MsoNormal">Brian<o:p></o:p></p>
</div>
<hr align="center" width="100%">
<span style="font-size:12pt;line-height:0.7;font-family: 'Arial'; color:#808080">The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the
addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly
appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.
</span>
</body>
</html>