Question of phosphor-sel-logger

[Matt Spinler]

On 3/24/2021 6:28 AM, Duke Du (杜祥嘉) wrote:
> Hi all,
>
>       I used package phosphor-hwmon and phospor-sel-logger to monitor sensor and create log when sensor reading
>     cross the threshold. I found after the commit 25b26e162bd109b51aa09b16f26f9aa3d9d940fa of phosphor-sel-logger
>     would catch the signal "ThresholdAsserted" to create sensor threhold log in the journal, but the phosphor-hwmon
>     would not send the signal "ThresholdAsserted" when sensor reading is abnormal so that phosphor-sel-logger
>     would not create the sensor threhold log, am I right ?
>
>     If I'm right, can you give me some suggestion to fix this side effect, or what setting I have lost in the
>     phosphor-hwmon or phosphor-sel-logger ?

Hi,
That signal isn't defined in phosphor-dbus-interfaces, so phosphor-hwmon 
cannot use it.  When I tried to add it, it was rejected as-is with a 
recommendation to break it up into separate signals for each alarm 
property on each interface.  At that point I gave up and had the code I 
was working on at the time just look at propertiesChanged signals instead.

If you would like to take that up it would entail:
* Update 
https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-dbus-interfaces/+/39899 
as requested
* Update phosphor-hwmon to emit the new signals
* Update phosphor-sel-logger to also listen for these new signals in 
addition to the  current one, or change the dbus-sensors code to only 
emit the new signals.


>     phosphor-sel-logger commit 25b26e162bd109b51aa09b16f26f9aa3d9d940fa link :
>     https://github.com/openbmc/phosphor-sel-logger/commit/25b26e162bd109b51aa09b16f26f9aa3d9d940fa
>
>     Thanks very much !
>     Duke