[PATCH 1/8] dt-bindings: arm/npcm: Add binding for global control registers (GCR)

Jonathan Neuschäfer j.neuschaefer at gmx.net
Sun Jun 13 19:20:12 AEST 2021


On Fri, Jun 04, 2021 at 10:00:18AM +0200, Linus Walleij wrote:
> On Wed, Jun 2, 2021 at 2:04 PM Jonathan Neuschäfer
> <j.neuschaefer at gmx.net> wrote:
> 
> > A nuvoton,*-gcr node is present in nuvoton-common-npcm7xx.dtsi and will
> > be added to nuvoton-wpcm450.dtsi. It is necessary for the NPCM7xx and
> > WPCM450 pinctrl drivers, and may later be used to retrieve SoC model and
> > version information.
> >
> > This patch adds a binding to describe this node.
> >
> > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
> 
> (...)
> 
> > +    gcr: gcr at 800000 {
> > +      compatible = "nuvoton,npcm750-gcr", "syscon", "simple-mfd";
> > +      reg = <0x800000 0x1000>;
> > +    };
> 
> gcr looks a bit idiomatic, isn't
> 
> syscon:  syscon at ... better?

I think I'll go with syscon at ..., because it's the right generic name,
but gcr for the label, matching current usage.

> Nitpicky though and looks good to me either way:
> Reviewed-by: Linus Walleij <linus.walleij at linaro.org>

Thanks!


Jonathan Neuschäfer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20210613/85c8f205/attachment.sig>


More information about the openbmc mailing list