[PATCH 1/8] dt-bindings: arm/npcm: Add binding for global control registers (GCR)

Linus Walleij linus.walleij at linaro.org
Fri Jun 4 18:00:18 AEST 2021

On Wed, Jun 2, 2021 at 2:04 PM Jonathan Neuschäfer
<j.neuschaefer at gmx.net> wrote:

> A nuvoton,*-gcr node is present in nuvoton-common-npcm7xx.dtsi and will
> be added to nuvoton-wpcm450.dtsi. It is necessary for the NPCM7xx and
> WPCM450 pinctrl drivers, and may later be used to retrieve SoC model and
> version information.
> This patch adds a binding to describe this node.
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer at gmx.net>


> +    gcr: gcr at 800000 {
> +      compatible = "nuvoton,npcm750-gcr", "syscon", "simple-mfd";
> +      reg = <0x800000 0x1000>;
> +    };

gcr looks a bit idiomatic, isn't

syscon:  syscon at ... better?

Nitpicky though and looks good to me either way:
Reviewed-by: Linus Walleij <linus.walleij at linaro.org>

Linus Walleij

More information about the openbmc mailing list