OPENBMC ASRock Rack

[Ed Tanous]

On Wed, Jul 7, 2021 at 6:50 PM Jeff9 Chan(陳松儉_ASRockRack)
<Jeff9_Chan at asrockrack.com> wrote:
>
> Hi,
>         It has been a while after uploading asrockrack layer, looks like no one is reviewing it, what's the next step for me?

I responded to your gerrit review with next steps, primarily educating
yourself on what is allowed in a meta layer, how big patches should
be, and where patches need to be submitted (which are documented in
the docs folder).  Apologies for letting it sit for so long, I was
hoping that you would read the relevant docs and start
updating/submitting your patches, but it looks like you were just
waiting.

-Ed

>
> https://gerrit.openbmc-project.xyz/c/openbmc/openbmc/+/43850
>
>
> best regards
>
> Jeff Chan
> ASRock Inc.
> Tel: +886-2-55599600 ext.38670
>
>
> -----Original Message-----
> From: Jeff9 Chan(陳松儉_ASRockRack)
> Sent: Tuesday, June 8, 2021 2:48 PM
> To: 'Joel Stanley'
> Cc: Bradley W Bishop; openbmc at lists.ozlabs.org; manager at lfprojects.org
> Subject: RE: OPENBMC ASRock Rack
>
> Thanks Joel, it works now.
>
> best regards
>
> Jeff Chan
> ASRock Inc.
> Tel: +886-2-55599600 ext.38670
>
>
> -----Original Message-----
> From: Joel Stanley [mailto:joel at jms.id.au]
> Sent: Tuesday, June 8, 2021 2:00 PM
> To: Jeff9 Chan(陳松儉_ASRockRack)
> Cc: Bradley W Bishop; openbmc at lists.ozlabs.org; manager at lfprojects.org
> Subject: Re: OPENBMC ASRock Rack
>
> On Tue, 8 Jun 2021 at 02:01, Jeff9 Chan(陳松儉_ASRockRack)
> <Jeff9_Chan at asrockrack.com> wrote:
> >
> > Re-send
>
> Please use plain text email when posting to the list. This is a good
> rule to follow for all open source mailing lists.
>
> >         I got below error when I try to push meta-asrockrack layer to gerrit.
> >
> >         Is that means my email is not listed in the list?
> >
> >
> >
> > To ssh://openbmc.gerrit/openbmc/openbmc
> >
> > ! [remote rejected]     HEAD -> refs/for/master (commit 1d9951c: not Signed-off-by author/committer/uploader in message footer)
>
> Here is the error:
>
>   (commit 1d9951c: not Signed-off-by author/committer/uploader in
> message footer)
>
> > commit 1d9951c5518a7bdf88a5de16a41ae2f337e1b2ed (HEAD -> master)
> >
> > Author: Jeff9Chan <jeff9_chan at asrockrack.com>
> >
> > Date:   Tue Jun 8 09:15:44 2021 +0800
> >
> >
> >
> >     add meta-asrockrack layer
> >
> >     Signed-off-by: Jeff Chan <Jeff9_Chan at asrockrack.com>
> >
> >
> >
> >     Change-Id: I1686133e0093e4e00adeadc068972396c8dc4fab
>
>  I suspect Gerrit's filtering diddn't notice the s-o-b in the middle
> of your commit message. Normal style is to place it at the bottom of
> the on the line immediately above or below the change id. Try git
> commit --amend and moving it so the message looks like this:
>
> Add meta-asrockrack layer
>
> Change-Id: I1686133e0093e4e00adeadc068972396c8dc4fab
> Signed-off-by: Jeff Chan <Jeff9_Chan at asrockrack.com>
>
> Cheers,
>
> Joel