Switch SensorCollection to show all sensors as new power/thermal schemas implemented

Gunnar Mills gmills at linux.vnet.ibm.com
Wed Jan 20 05:20:54 AEDT 2021


On 1/11/2021 11:19 AM, Gunnar Mills wrote:
> Similar discussion has been on the mailing list before: 
> https://lists.ozlabs.org/pipermail/openbmc/2020-October/023568.html
> 
> The new PowerSubsystem/ThermalSubsystem Redfish schemas can coexist with 
> the old Power/Thermal schemas. I suspect we will have both the new and 
> old for some time. As we implement the new 
> PowerSubsystem/ThermalSubsystem is it okay to switch the behavior of the 
> sensor collection from "show sensors that are not covered elsewhere in 
> the model" to "show all sensors" as the new 
> PowerSubsystem/ThermalSubsystem schemas call for?
> 
> I reposted in 
> https://redfishforum.com/thread/190/sensorcollection-contain-all-sensors-chassis, 
> unless I am missing something I believe Redfish's guidance will be "move 
> to a SensorCollection that shows all the sensors". If indeed that is 
> their guidance, is everyone okay as we implement the new 
> PowerSubsystem/ThermalSubsystem in bmcweb, we move sensor collection to 
> show all sensors? Things like webui-vue will have to be updated (not 
> sure anything breaks for webui-vue just would have duplicate sensors).

Redfish's reply was "My statement from 18 months ago is no longer our 
recommendation. That was before we proposed to re-factor the Power and 
Thermal schemas to use the Sensor model. And that continues to be our 
direction. So in that light, we want everything that counts as a 
"sensor" to be part of the Sensor collection so that generic monitoring 
software can be built to harvest sensor data across the Redfish model.

Even if an implementation hasn't decided to adopt the (still a 
work-in-progress) PowerSubystem and ThermalSubsystem models, the 
underlying temperature and fan sensors can be rendered as Redfish Sensor 
resources as a good middle ground (and a step in the right direction for 
future work).".

Based on that reply, I propose we move Redfish SensorCollection to show 
all sensors. Let me know if anyone objects.

Thanks,
Gunnar


More information about the openbmc mailing list