[PATCH u-boot v2019.04-aspeed-openbmc] pinctrl: ast2400: add support for TXD3/RXD3 pins

[Ryan Chen]

Hello,
	You may need claim for function group for link, not for pin link.
	Ex. 
	static struct aspeed_sig_desc uart3_link[] = {
		{ 0x80, BIT(22), 0},
		{ 0x80, BIT(23), 0},
	}

	ast2400_groups[] = {
	{ "UART3", 2, uart3_link },
Ryan
> -----Original Message-----
> From: Zev Weiss <zev at bewilderbeest.net>
> Sent: Tuesday, December 14, 2021 3:47 AM
> To: openbmc at lists.ozlabs.org; Joel Stanley <joel at jms.id.au>
> Cc: Zev Weiss <zev at bewilderbeest.net>; Ryan Chen
> <ryan_chen at aspeedtech.com>
> Subject: [PATCH u-boot v2019.04-aspeed-openbmc] pinctrl: ast2400: add
> support for TXD3/RXD3 pins
> 
> In order to support putting the u-boot console on UART3 of the ast2400, this
> commit adds support for setting bits 22 and 23 of SCU80 to enable TXD3 and
> RXD3 on pins C14 and B14, respectively.
> 
> Signed-off-by: Zev Weiss <zev at bewilderbeest.net>
> ---
>  drivers/pinctrl/aspeed/pinctrl_ast2400.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/pinctrl/aspeed/pinctrl_ast2400.c
> b/drivers/pinctrl/aspeed/pinctrl_ast2400.c
> index 7a6c2892f469..a8a5ff517108 100644
> --- a/drivers/pinctrl/aspeed/pinctrl_ast2400.c
> +++ b/drivers/pinctrl/aspeed/pinctrl_ast2400.c
> @@ -125,6 +125,14 @@ static struct aspeed_sig_desc spi1_link[] = {
>  	{ 0x70, BIT(12), 0},
>  };
> 
> +static struct aspeed_sig_desc txd3_link[] = {
> +	{ 0x80, BIT(22), 0},
> +};
> +
> +static struct aspeed_sig_desc rxd3_link[] = {
> +	{ 0x80, BIT(23), 0},
> +};
> +
>  static const struct aspeed_group_config ast2400_groups[] = {
>  	{ "MAC1LINK", 1, mac1_link },
>  	{ "MAC2LINK", 1, mac2_link },
> @@ -146,6 +154,8 @@ static const struct aspeed_group_config
> ast2400_groups[] = {
>  	{ "SD1", 1, sdio1_link },
>  	{ "SPI1", 1, spi1_link},
>  	{ "SPI1CS1", 1, spi1cs1_link},
> +	{ "TXD3", 1, txd3_link },
> +	{ "RXD3", 1, rxd3_link },
>  };
> 
>  static int ast2400_pinctrl_get_groups_count(struct udevice *dev)
> --
> 2.34.1