[phosphor-virtual-sensor] get sensor service fail

[Alan Kuo (郭振維)]

Hi all,

In the current implementation of bmcweb LogServices, the time of the "Created" property is the time when the event is generated, which does not match the description of the redfish schema. The "Created" property means the date and time when the log entry was created.
We think that using “EventTimestamp” will be more suitable than “Created” in LogServices.

Could you give me some suggestion ? Or am I misunderstanding the definition of schema?

Here is an example:
{
      "@odata.id": "/redfish/v1/Systems/system/LogServices/PostCodes/Entries/B5-83",
      "@odata.type": "#LogEntry.v1_4_0.LogEntry",
      "Created": "1970-01-01T00:01:43+00:00",    <=  It should be EventTimestamp
      "EntryType": "Event",
      "Id": "B5-83",
      "Message": "Boot Count: 1: TS Offset: 65.4769; POST Code: 0x01",
      "MessageArgs": [
        "1",
        "65.4769",
        "0x01"
      ],
      "MessageId": "OpenBMC.0.1.BIOSPOSTCode",
      "Name": "POST Code Log Entry",
      "Severity": "OK"
}

Thanks,
Alan

From: openbmc <openbmc-bounces+alan_kuo=quantatw.com at lists.ozlabs.org> On Behalf Of Harvey Wu (吳崇維)
Sent: Monday, March 29, 2021 5:14 PM
To: openbmc at lists.ozlabs.org
Cc: Duke Du (杜祥嘉) <Duke.Du at quantatw.com>; Fran Hsu (徐誌謙) <Fran.Hsu at quantatw.com>; George Hung (洪忠敬) <George.Hung at quantatw.com>
Subject: [phosphor-virtual-sensor] get sensor service fail

Hi All,

        In current phosphor-virtual-sensor, the function getService will return empty string only when catch error name = “xyz.openbmc_project.Common.Error.ResourceNotFound” (https://github.com/openbmc/phosphor-virtual-sensor/blob/master/dbusUtils.hpp#L37<https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fopenbmc%2Fphosphor-virtual-sensor%2Fblob%2Fmaster%2FdbusUtils.hpp%23L37&data=04%7C01%7CAlan_Kuo%40quantatw.com%7Ccde1ecb7b4fe46832a9608d8f2932ad4%7C179b032707fc4973ac738de7313561b2%7C1%7C0%7C637526061215310813%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=5J%2FUr5bZvLFr%2FrFOih%2Bh8QufHoy8wcXmEn8yU6K%2FcOM%3D&reserved=0>).
        But in my system, when bus call didn’t get sensor service, the exception name will be “org.freedesktop.DBus.Error.FileNotFound”, and then service will be get failed.
        It seems need to modified the origin condition or add another elseif condition. Do I misunderstand something?


Thanks.

Harvey Wu
Email: Harvey.Wu at quantatw.com<mailto:Harvey.Wu at quantatw.com>
Ext: 17408

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20210408/45a0ec47/attachment.htm>