Need update CI build config for new repo smbios-mdr.
Wang, Kuiying
kuiying.wang at intel.com
Thu Sep 3 14:17:29 AEST 2020
Thanks a lot.
It's done https://gerrit.openbmc-project.xyz/#/c/openbmc/smbios-mdr/+/36177/
Thanks,
Kwin.
-----Original Message-----
From: Patrick Williams <patrick at stwcx.xyz>
Sent: Wednesday, September 2, 2020 11:50 PM
To: Wang, Kuiying <kuiying.wang at intel.com>
Cc: openbmc at lists.ozlabs.org; Brad Bishop <bradleyb at fuzziesquirrel.com>
Subject: Re: Need update CI build config for new repo smbios-mdr.
On Wed, Sep 02, 2020 at 02:02:00AM +0000, Wang, Kuiying wrote:
> Hi Williams,
> The key thing is sdbusplus interface is not match.
> You could config CI based on this patch
> https://gerrit.openbmc-project.xyz/#/c/openbmc/smbios-mdr/+/36011/
> That's ok, if it can pass the build.
>
> Thanks,
> Kwin.
>
Here is a snippet of the compile log:
/home/jenkins-slave/workspace/ci-repository/openbmc/smbios-mdr/src/cpuinfo_main.cpp:34:10: fatal error: peci.h: No such file or directory
34 | #include <peci.h>
| ^~~~~~~~
compilation terminated.
This one might be a missing dependency? Where is 'peci.h' from? Is it from a kernel header for the ioctls or some other repository? Do you need to stub this out when building on x86?
make[2]: *** [CMakeFiles/cpuinfoapp.dir/build.make:63: CMakeFiles/cpuinfoapp.dir/src/cpuinfo_main.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:78: CMakeFiles/cpuinfoapp.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
In file included from /home/jenkins-slave/workspace/ci-repository/openbmc/smbios-mdr/src/cpu.cpp:17:
/home/jenkins-slave/workspace/ci-repository/openbmc/smbios-mdr/include/cpu.hpp:113:17: error: âstd::string phosphor::smbios::Cpu::processorSocket(std::string)â marked âoverrideâ, but does not override
113 | std::string processorSocket(std::string value) override;
This appears to be a case where the current phosphor-dbus-interfaces doesn't match whatever your commit is trying to do. You've got additional methods for handling dbus properties, but those properties do not exist in phosphor-dbus-interface's Cpu interface.
I suspect you're trying to implement
xyz/openbmc_project/Inventory/Item/Cpu, which has a 'Socket' property but not a 'ProcessorSocket'. If I recall, this happened in the code review where the "Processor" part was requested to be removed since it was redundant.
There are a number of other properties in your compile fail that need similar updating.
--
Patrick Williams
More information about the openbmc
mailing list