Sensor value is not accurate which is generated by phosphor-hwmon

[Duke Du (杜祥嘉)]

Hi Matt,

  Sorry for late, I will try this commit in our project, it looks good to me, thanks for your help.

thanks
Duke
> -----Original Message-----
> From: Matt Spinler <mspinler at linux.ibm.com>
> Sent: Thursday, July 9, 2020 2:38 AM
> To: Duke Du (杜祥嘉) <Duke.Du at quantatw.com>; openbmc at lists.ozlabs.org
> Cc: Eddie Lu (陸宇岡) <Eddie.Lu at quantatw.com>; Fran Hsu (徐誌謙)
> <Fran.Hsu at quantatw.com>; George Hung (洪忠敬)
> <George.Hung at quantatw.com>
> Subject: Re: Sensor value is not accurate which is generated by
> phosphor-hwmon
> 
> 
> 
> On 7/7/2020 12:48 PM, Matt Spinler wrote:
> >
> >
> > On 7/6/2020 9:15 PM, Duke Du (杜祥嘉) wrote:
> >>
> >> Hi All,
> >>
> >>   I found sensor value type is changed to double in
> >>
> >> xyz/openbmc_project/Sensor/Value.interface.yaml,
> >>
> >> after this change, the sensor value on the interface
> >>
> >> xyz.openbmc_project.Sensor.Value which is generated by
> >>
> >> phosphor-hwmon is not accurate, for example, 0.99 volts
> >>
> >> would be record 0 volts on the interface. Do I miss some
> >>
> >> configuration for phosphor-hwmon ?
> >>
> >
> > Looks like that is indeed a problem.  I haven't looked closely yet,
> > but I wonder if how the code is attempting to support Sensor.Value as
> > both an int64 and a double at the same time has an issue.
> >
> > Maybe now would be a good time to just support the double version.
> > I can take a look.
> 
> https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-hwmon/+/34481
> 
> >
> >> Sensor value type is changed to double, which commit is :
> >>
> >> 4ec6587fa908fe9df41cc0962ab6ff6446fbd54f
> >>
> https://github.com/openbmc/phosphor-dbus-interfaces/commit/4ec6587fa9
> >> 08fe9df41cc0962ab6ff6446fbd54f
> >>
> >>
> >> Thanks.
> >>
> >> Duke Du
> >>
> >