dbus-sensor: setting the upper non-critical(unc) threshold value smaller than reading value would get 3 logs ( assert log, de-assert log and then assert log)

[Max Lai/WYHQ/Wiwynn]

Hi James,

Sorry for I offered the wrong information. The last mail this sentence "struct sensor's "objectType" member which was set "xyz.openbmc_project.Configuration.ExitAirTemp" was different than our "xyz.openbmc_project.EntityManager"." is wrong. The correct information is "struct sensor's "objectType" member which was set "xyz.openbmc_project.Configuration.ExitAirTemp" was different than our "xyz.openbmc_project.Configuration.IpmbSensor". The different is between "xyz.openbmc_project.Configuration.ExitAirTemp" and "xyz.openbmc_project.Configuration.IpmbSensor".



Upstream Source Revision : 241356e3dcff3e91393c858256ac29d003e6179e

[cid:image004.png at 01D5EBBE.164F0A50][cid:image002.png at 01D5EBB7.BF058450]



Our Source Revision : fb64f45d3399b182ceadffb8fa86ee68c0aa0a11

[cid:image004.png at 01D5EBBE.164F0A50][cid:image001.png at 01D5EBB7.48C83300]


Please let us know if you have any questions.

Thanks for your reply!

Engineer
Storage Firmware
Development Dept.
Firmware Development Div.

Wiwynn Corporation

Tel: +886-2-6614-7549
E-mail: Max_Lai at wiwynn.com<mailto:Max_Lai at wiwynn.com>



-----Original Message-----
From: James Feist <james.feist at linux.intel.com>
Sent: Tuesday, February 25, 2020 4:38 AM
To: Max Lai/WYHQ/Wiwynn <Max_Lai at wiwynn.com>
Cc: openbmc at lists.ozlabs.org; LF_OpenBMC.WYHQ.Wiwynn <LF_OpenBMC.WYHQ.Wiwynn at Wiwynn.com>
Subject: Re: dbus-sensor: setting the upper non-critical(unc) threshold value smaller than reading value would get 3 logs ( assert log, de-assert log and then assert log)



On 2/24/20 3:31 AM, Max Lai/WYHQ/Wiwynn wrote:

> Hi James,

>

> We had tried your fix solution (Deleting lines 117 and 118). Deleting

> the lines 117 and 118 would stop sending the PropertiesChanged signal

> and even stop updating threshold value on Dbus. The result we want is

> we can change threshold value on Dbus and get assert sel log when we

> trigger the threshold mechanism. And we also tried the latest source

> revision on upstream dbus-sensor repository. We found that latest

> source revision in IpmbSensor.cpp, struct sensor's "objectType" member

> which was set "xyz.openbmc_project.Configuration.ExitAirTemp" was

> different than our "xyz.openbmc_project.EntityManager". So this issue doesn't happen.

>

> What's the purpose of this changing?



Can you send a diff? I'm not exactly sure the line you're mentioning.





---------------------------------------------------------------------------------------------------------------------------------------------------------------
This email contains confidential or legally privileged information and is for the sole use of its intended recipient. 
Any unauthorized review, use, copying or distribution of this email or the content of this email is strictly prohibited.
If you are not the intended recipient, you may reply to the sender and should delete this e-mail immediately.
---------------------------------------------------------------------------------------------------------------------------------------------------------------
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20200225/4c846f59/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.png
Type: image/png
Size: 31699 bytes
Desc: image001.png
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20200225/4c846f59/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image002.png
Type: image/png
Size: 30368 bytes
Desc: image002.png
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20200225/4c846f59/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image004.png
Type: image/png
Size: 255 bytes
Desc: image004.png
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20200225/4c846f59/attachment-0005.png>