<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:PMingLiU;
panose-1:2 2 5 0 0 0 0 0 0 0;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:PMingLiU;
panose-1:2 1 6 1 0 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
{mso-style-priority:99;
mso-style-link:"\7D14\6587\5B57 \5B57\5143";
margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Calibri",sans-serif;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
span.a
{mso-style-name:"\7D14\6587\5B57 \5B57\5143";
mso-style-priority:99;
mso-style-link:\7D14\6587\5B57;
font-family:"Calibri",sans-serif;}
span.EmailStyle20
{mso-style-type:personal-compose;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
/* Page Definitions */
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 90.0pt 72.0pt 90.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1028" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="ZH-TW" link="#0563C1" vlink="#954F72" style="text-justify-trim:punctuation">
<div class="WordSection1">
<p class="MsoPlainText"><span lang="EN-US">Hi James,<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Sorry for I offered the wrong information. The last mail this sentence "struct sensor's "objectType" member which was set "xyz.openbmc_project.Configuration.ExitAirTemp" was different than our "<span style="color:red">xyz.openbmc_project.EntityManager</span>"."
is <b><span style="color:red">wrong</span></b>. The <b><span style="color:red">correct</span></b><span style="color:red">
</span>information is "struct sensor's "objectType" member which was set "xyz.openbmc_project.Configuration.ExitAirTemp" was different than our "<b><span style="color:red">xyz.openbmc_project.Configuration.IpmbSensor</span></b>". The different is between "xyz.openbmc_project.Configuration.<b>ExitAirTemp</b>"
and "xyz.openbmc_project.Configuration.<b>IpmbSensor</b>".<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><b><span lang="EN-US">Upstream Source Revision : 241356e3dcff3e91393c858256ac29d003e6179e<o:p></o:p></span></b></p>
<p class="MsoPlainText"><!--[if gte vml 1]><v:shapetype id="_x0000_t75" coordsize="21600,21600" o:spt="75" o:preferrelative="t" path="m@4@5l@4@11@9@11@9@5xe" filled="f" stroked="f">
<v:stroke joinstyle="miter" />
<v:formulas>
<v:f eqn="if lineDrawn pixelLineWidth 0" />
<v:f eqn="sum @0 1 0" />
<v:f eqn="sum 0 0 @1" />
<v:f eqn="prod @2 1 2" />
<v:f eqn="prod @3 21600 pixelWidth" />
<v:f eqn="prod @3 21600 pixelHeight" />
<v:f eqn="sum @0 0 1" />
<v:f eqn="prod @6 1 2" />
<v:f eqn="prod @7 21600 pixelWidth" />
<v:f eqn="sum @8 21600 0" />
<v:f eqn="prod @7 21600 pixelHeight" />
<v:f eqn="sum @10 21600 0" />
</v:formulas>
<v:path o:extrusionok="f" gradientshapeok="t" o:connecttype="rect" />
<o:lock v:ext="edit" aspectratio="t" />
</v:shapetype><v:shape id="_x77e9__x5f62__x0020_2" o:spid="_x0000_s1027" type="#_x0000_t75" style='position:absolute;margin-left:63pt;margin-top:130.35pt;width:275.25pt;height:16.5pt;z-index:251659264;visibility:visible;mso-wrap-distance-left:9pt;mso-wrap-distance-top:0;mso-wrap-distance-right:9pt;mso-wrap-distance-bottom:0;mso-position-horizontal:absolute;mso-position-horizontal-relative:text;mso-position-vertical:absolute;mso-position-vertical-relative:text'>
<v:imagedata src="cid:image004.png@01D5EBBE.164F0A50" o:title="" />
<o:lock v:ext="edit" aspectratio="f" />
</v:shape><![endif]--><![if !vml]><span style="mso-ignore:vglayout;position:absolute;z-index:251659264;margin-left:84px;margin-top:174px;width:367px;height:22px"><img width="367" height="22" style="width:3.8229in;height:.2291in" src="cid:image004.png@01D5EBBE.164F0A50" v:shapes="_x77e9__x5f62__x0020_2"></span><![endif]><span lang="EN-US"><img width="590" height="215" style="width:6.1458in;height:2.2395in" id="_x5716__x7247__x0020_1" src="cid:image002.png@01D5EBB7.BF058450"><o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><b><span lang="EN-US">Our Source Revision : fb64f45d3399b182ceadffb8fa86ee68c0aa0a11<o:p></o:p></span></b></p>
<p class="MsoPlainText"><!--[if gte vml 1]><v:shape id="_x77e9__x5f62__x0020_3" o:spid="_x0000_s1026" type="#_x0000_t75" style='position:absolute;margin-left:60.75pt;margin-top:144.45pt;width:275.25pt;height:16.5pt;z-index:251661312;visibility:visible;mso-wrap-distance-left:9pt;mso-wrap-distance-top:0;mso-wrap-distance-right:9pt;mso-wrap-distance-bottom:0;mso-position-horizontal:absolute;mso-position-horizontal-relative:text;mso-position-vertical:absolute;mso-position-vertical-relative:text'>
<v:imagedata src="cid:image004.png@01D5EBBE.164F0A50" o:title="" />
<o:lock v:ext="edit" aspectratio="f" />
</v:shape><![endif]--><![if !vml]><span style="mso-ignore:vglayout;position:absolute;z-index:251661312;margin-left:81px;margin-top:192px;width:367px;height:22px"><img width="367" height="22" style="width:3.8229in;height:.2291in" src="cid:image004.png@01D5EBBE.164F0A50" v:shapes="_x77e9__x5f62__x0020_3"></span><![endif]><span lang="EN-US"><img width="583" height="233" style="width:6.0729in;height:2.427in" id="_x0000_i1026" src="cid:image001.png@01D5EBB7.48C83300" alt="cid:image001.png@01D5EBB7.48C83300"></span><span lang="EN-US"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Please let us know if you have any questions.<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Thanks for your reply!<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D">Engineer</span><span lang="EN-US" style="color:#1F497D"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D">Storage Firmware<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D">Development Dept.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D">Firmware Development Div.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:black"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:black">Wiwynn Corporation<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:black"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:black">Tel: +886-2-6614-7549<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D">E-mail:</span><span lang="EN-US" style="color:#002060">
<a href="mailto:Max_Lai@wiwynn.com"><span style="color:#0563C1">Max_Lai@wiwynn.com</span></a></span><span lang="EN-US" style="color:#1F497D"><o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">-----Original Message-----<br>
From: James Feist <james.feist@linux.intel.com> <br>
Sent: Tuesday, February 25, 2020 4:38 AM<br>
To: Max Lai/WYHQ/Wiwynn <Max_Lai@wiwynn.com><br>
Cc: openbmc@lists.ozlabs.org; LF_OpenBMC.WYHQ.Wiwynn <LF_OpenBMC.WYHQ.Wiwynn@Wiwynn.com><br>
Subject: Re: dbus-sensor: setting the upper non-critical(unc) threshold value smaller than reading value would get 3 logs ( assert log, de-assert log and then assert log)<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">On 2/24/20 3:31 AM, Max Lai/WYHQ/Wiwynn wrote:<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> Hi James,<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> <o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> We had tried your fix solution (Deleting lines 117 and 118). Deleting
<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> the lines 117 and 118 would stop sending the PropertiesChanged signal
<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> and even stop updating threshold value on Dbus. The result we want is
<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> we can change threshold value on Dbus and get assert sel log when we
<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> trigger the threshold mechanism. And we also tried the latest source
<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> revision on upstream dbus-sensor repository. We found that latest
<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> source revision in IpmbSensor.cpp, struct sensor's "objectType" member
<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> which was set "xyz.openbmc_project.Configuration.ExitAirTemp" was
<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> different than our "xyz.openbmc_project.EntityManager". So this issue doesn</span><span lang="EN-US" style="font-family:"Courier New"">’</span><span lang="EN-US">t happen.<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> <o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> What's the purpose of this changing?<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Can you send a diff? I'm not exactly sure the line you're mentioning.<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
</div>
<p><span style="font-family:'Calibri';font-size:11pt; color:#000000;"><b>---------------------------------------------------------------------------------------------------------------------------------------------------------------</b></span></p>
<p><span style="font-family:'Calibri';font-size:11pt; color:#000000;"><b>This email contains confidential or legally privileged information and is for the sole use of its intended recipient. </b></span></p>
<p><span style="font-family:'Calibri';font-size:11pt; color:#000000;"><b>Any unauthorized review, use, copying or distribution of this email or the content of this email is strictly prohibited.</b></span></p>
<p><span style="font-family:'Calibri';font-size:11pt; color:#000000;"><b>If you are not the intended recipient, you may reply to the sender and should delete this e-mail immediately.</b></span></p>
<p><span style="font-family:'Calibri';font-size:11pt; color:#000000;"><b>---------------------------------------------------------------------------------------------------------------------------------------------------------------</b></span></p></body>
</html>