dbus-sensor: setting the upper non-critical(unc) threshold value smaller than reading value would get 3 logs ( assert log, de-assert log and then assert log)

Mon Feb 24 22:31:42 AEDT 2020

Hi James,

We had tried your fix solution (Deleting lines 117 and 118). Deleting the lines 117 and 118 would stop sending the PropertiesChanged signal and even stop updating threshold value on Dbus. The result we want is we can change threshold value on Dbus and get assert sel log when we trigger the threshold mechanism. And we also tried the latest source revision on upstream dbus-sensor repository. We found that latest source revision in IpmbSensor.cpp, struct sensor's "objectType" member which was set "xyz.openbmc_project.Configuration.ExitAirTemp" was different than our "xyz.openbmc_project.EntityManager". So this issue doesn't happen.

[cid:image001.png at 01D5EB48.36B03D30]

What's the purpose of this changing?

Engineer
Storage Firmware
Development Dept.
Firmware Development Div.

Wiwynn Corporation

Tel: +886-2-6614-7549
E-mail: Max_Lai at wiwynn.com<mailto:Max_Lai at wiwynn.com>

-----Original Message-----
From: James Feist <james.feist at linux.intel.com>
Sent: Thursday, February 20, 2020 1:11 AM
To: Max Lai/WYHQ/Wiwynn <Max_Lai at wiwynn.com>
Cc: openbmc at lists.ozlabs.org; Delphine Chiu/WYHQ/Wiwynn <DELPHINE_CHIU at wiwynn.com>; Bonnie Lo/WYHQ/Wiwynn <Bonnie_Lo at wiwynn.com>
Subject: Re: dbus-sensor: setting the upper non-critical(unc) threshold value smaller than reading value would get 3 logs ( assert log, de-assert log and then assert log)

Because configurations can change at runtime. For instance if you change a threshold, or you add/remove a card. This gets persisted back to entity-manager

https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fopenbmc%2Fdbus-sensors%2Fblob%2Fa97f1343379bbb52371195bc613a689cbfb374f3%2Fsrc%2FThresholds.cpp%23L118&data=02%7C01%7CMax_Lai%40wiwynn.com%7Ca8d9411b7f9647a0174108d7b55eccb5%7Cde0795e0d7c04eebb9bbbc94d8980d3b%7C1%7C0%7C637177291088060436&sdata=QrbRo%2BqQjKQelorhW4zxp9DUcwsyxBZl5b%2BKXCnTC98%3D&reserved=0

and that will trigger an update.

I'm guessing this todo is what is needed to fix your issue:

https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fopenbmc%2Fdbus-sensors%2Fblob%2Fa97f1343379bbb52371195bc613a689cbfb374f3%2Finclude%2Fsensor.hpp%23L117&data=02%7C01%7CMax_Lai%40wiwynn.com%7Ca8d9411b7f9647a0174108d7b55eccb5%7Cde0795e0d7c04eebb9bbbc94d8980d3b%7C1%7C0%7C637177291088060436&sdata=dl3PecBITgFAmtRJSNsCitl5e8dkqd%2BVWFSmHysStJM%3D&reserved=0

I was wondering when I wrote this if the config can just update the threshold, and updating it locally was not needed. Deleting lines 117 and 118 might fix your issue.

---------------------------------------------------------------------------------------------------------------------------------------------------------------
This email contains confidential or legally privileged information and is for the sole use of its intended recipient. 
Any unauthorized review, use, copying or distribution of this email or the content of this email is strictly prohibited.
If you are not the intended recipient, you may reply to the sender and should delete this e-mail immediately.
---------------------------------------------------------------------------------------------------------------------------------------------------------------
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20200224/eef2c357/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.png
Type: image/png
Size: 30368 bytes
Desc: image001.png
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20200224/eef2c357/attachment-0001.png>