<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:PMingLiU;
panose-1:2 2 5 0 0 0 0 0 0 0;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:PMingLiU;
panose-1:2 1 6 1 0 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
{mso-style-priority:99;
mso-style-link:"\7D14\6587\5B57 \5B57\5143";
margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Calibri",sans-serif;}
span.a
{mso-style-name:"\7D14\6587\5B57 \5B57\5143";
mso-style-priority:99;
mso-style-link:\7D14\6587\5B57;
font-family:"Calibri",sans-serif;}
.MsoChpDefault
{mso-style-type:export-only;}
/* Page Definitions */
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 90.0pt 72.0pt 90.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="ZH-TW" link="#0563C1" vlink="#954F72" style="text-justify-trim:punctuation">
<div class="WordSection1">
<p class="MsoPlainText"><span lang="EN-US">Hi James,<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">We had tried your fix solution (Deleting lines 117 and 118). Deleting the lines 117 and 118 would stop sending the PropertiesChanged signal and even stop updating threshold value on Dbus. The result we want is we can
change threshold value on Dbus and get assert sel log when we trigger the threshold mechanism. And we also tried the latest source revision on upstream dbus-sensor repository. We found that latest source revision in IpmbSensor.cpp, struct sensor's "objectType"
member which was set "xyz.openbmc_project.Configuration.ExitAirTemp" was different than our "xyz.openbmc_project.EntityManager". So this issue doesn</span><span lang="EN-US" style="font-family:"Courier New"">’</span><span lang="EN-US">t happen.<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><img width="590" height="215" style="width:6.1458in;height:2.2395in" id="_x5716__x7247__x0020_1" src="cid:image001.png@01D5EB48.36B03D30"></span><span lang="EN-US"><o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">What's the purpose of this changing?<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D">Engineer</span><span lang="EN-US" style="color:#1F497D"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D">Storage Firmware<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D">Development Dept.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D">Firmware Development Div.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:black"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:black">Wiwynn Corporation<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:black"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:black">Tel: +886-2-6614-7549<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D">E-mail:</span><span lang="EN-US" style="color:#002060">
<a href="mailto:Max_Lai@wiwynn.com"><span style="color:#0563C1">Max_Lai@wiwynn.com</span></a></span><span lang="EN-US" style="color:#1F497D"><o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">-----Original Message-----<br>
From: James Feist <james.feist@linux.intel.com> <br>
Sent: Thursday, February 20, 2020 1:11 AM<br>
To: Max Lai/WYHQ/Wiwynn <Max_Lai@wiwynn.com><br>
Cc: openbmc@lists.ozlabs.org; Delphine Chiu/WYHQ/Wiwynn <DELPHINE_CHIU@wiwynn.com>; Bonnie Lo/WYHQ/Wiwynn <Bonnie_Lo@wiwynn.com><br>
Subject: Re: dbus-sensor: setting the upper non-critical(unc) threshold value smaller than reading value would get 3 logs ( assert log, de-assert log and then assert log)</span></p>
<p class="MsoPlainText"><span lang="EN-US" style="color:black"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Because configurations can change at runtime. For instance if you change a threshold, or you add/remove a card. This gets persisted back to entity-manager<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><a href="https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fopenbmc%2Fdbus-sensors%2Fblob%2Fa97f1343379bbb52371195bc613a689cbfb374f3%2Fsrc%2FThresholds.cpp%23L118&data=02%7C01%7CMax_Lai%40wiwynn.com%7Ca8d9411b7f9647a0174108d7b55eccb5%7Cde0795e0d7c04eebb9bbbc94d8980d3b%7C1%7C0%7C637177291088060436&sdata=QrbRo%2BqQjKQelorhW4zxp9DUcwsyxBZl5b%2BKXCnTC98%3D&reserved=0"><span style="color:windowtext;text-decoration:none">https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fopenbmc%2Fdbus-sensors%2Fblob%2Fa97f1343379bbb52371195bc613a689cbfb374f3%2Fsrc%2FThresholds.cpp%23L118&data=02%7C01%7CMax_Lai%40wiwynn.com%7Ca8d9411b7f9647a0174108d7b55eccb5%7Cde0795e0d7c04eebb9bbbc94d8980d3b%7C1%7C0%7C637177291088060436&sdata=QrbRo%2BqQjKQelorhW4zxp9DUcwsyxBZl5b%2BKXCnTC98%3D&reserved=0</span></a><o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">and that will trigger an update.<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">I'm guessing this todo is what is needed to fix your issue:<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><a href="https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fopenbmc%2Fdbus-sensors%2Fblob%2Fa97f1343379bbb52371195bc613a689cbfb374f3%2Finclude%2Fsensor.hpp%23L117&data=02%7C01%7CMax_Lai%40wiwynn.com%7Ca8d9411b7f9647a0174108d7b55eccb5%7Cde0795e0d7c04eebb9bbbc94d8980d3b%7C1%7C0%7C637177291088060436&sdata=dl3PecBITgFAmtRJSNsCitl5e8dkqd%2BVWFSmHysStJM%3D&reserved=0"><span style="color:windowtext;text-decoration:none">https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fopenbmc%2Fdbus-sensors%2Fblob%2Fa97f1343379bbb52371195bc613a689cbfb374f3%2Finclude%2Fsensor.hpp%23L117&data=02%7C01%7CMax_Lai%40wiwynn.com%7Ca8d9411b7f9647a0174108d7b55eccb5%7Cde0795e0d7c04eebb9bbbc94d8980d3b%7C1%7C0%7C637177291088060436&sdata=dl3PecBITgFAmtRJSNsCitl5e8dkqd%2BVWFSmHysStJM%3D&reserved=0</span></a><o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">I was wondering when I wrote this if the config can just update the threshold, and updating it locally was not needed. Deleting lines 117 and 118 might fix your issue.<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p></o:p></span></p>
</div>
<p><span style="font-family:'Calibri';font-size:11pt; color:#000000;"><b>---------------------------------------------------------------------------------------------------------------------------------------------------------------</b></span></p>
<p><span style="font-family:'Calibri';font-size:11pt; color:#000000;"><b>This email contains confidential or legally privileged information and is for the sole use of its intended recipient. </b></span></p>
<p><span style="font-family:'Calibri';font-size:11pt; color:#000000;"><b>Any unauthorized review, use, copying or distribution of this email or the content of this email is strictly prohibited.</b></span></p>
<p><span style="font-family:'Calibri';font-size:11pt; color:#000000;"><b>If you are not the intended recipient, you may reply to the sender and should delete this e-mail immediately.</b></span></p>
<p><span style="font-family:'Calibri';font-size:11pt; color:#000000;"><b>---------------------------------------------------------------------------------------------------------------------------------------------------------------</b></span></p></body>
</html>