[PATCH linux dev-5.4] ARM: dts: aspeed: witherspoon: Add gpio line names

Andrew Geissler geissonator at gmail.com
Thu Feb 6 06:59:07 AEDT 2020

> On Feb 4, 2020, at 3:59 PM, Patrick Williams <patrick at stwcx.xyz> wrote:
> On Tue, Feb 04, 2020 at 03:30:37PM -0600, Andrew Geissler wrote:
>> From: Andrew Geissler <geissonator at yahoo.com>
>> Name the gpios so libgiod will work with them
>> Signed-off-by: Andrew Geissler <geissonator at yahoo.com>
> Great!  I love that you used logical names here rather than 
> schematic names too, so that the userspace functionality is
> more likely to be common across machines.  It'd be great if 
> we could start to document a list of "commonly used logical 
> GPIO names" (ex. power-button) to facilitate this sharing.

Yeah, I hadn’t really thought of that aspect but it’s a good
point. Joel seemed to have some thoughts on improving
conventions with naming in his review comments. I’ll
address those and send upstream. If upstream seems ok
with this direction then I can create a docs repo commit
that documents the conventions.

>> ---
>> .../boot/dts/aspeed-bmc-opp-witherspoon.dts   | 41 +++++++++++++++++++
>> 1 file changed, 41 insertions(+)
> -- 
> Patrick Williams

More information about the openbmc mailing list