[PATCH linux dev-5.4] ARM: dts: aspeed: witherspoon: Add gpio line names

[Joel Stanley]

On Tue, 4 Feb 2020 at 21:30, Andrew Geissler <geissonator at gmail.com> wrote:
>
> From: Andrew Geissler <geissonator at yahoo.com>
>
> Name the gpios so libgiod will work with them
>
> Signed-off-by: Andrew Geissler <geissonator at yahoo.com>

Please send to the upstream lists for review. CC the GPIO maintainers
too, so we can get their feedback.

> ---
>  .../boot/dts/aspeed-bmc-opp-witherspoon.dts   | 41 +++++++++++++++++++
>  1 file changed, 41 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> index 515f0f208ee6..d3bbd4fc2539 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> @@ -193,6 +193,47 @@
>
>  };
>
> +&gpio {
> +    status = "okay";
> +       gpio-line-names =
> +       /*A0-A7*/       "","cfam-reset","","","","","mux","",

fsi-mux

> +       /*B0-B7*/       "","","","","","air-water","","",
> +       /*C0-C7*/       "","","","","","","","",
> +       /*D0-D7*/       "enable","","","","","","","",
> +       /*E0-E7*/       "data","","","","","","","",

fsi-enable, fsi-data.

> +       /*F0-F7*/       "","","","","","","","",
> +       /*G0-G7*/       "","","","","","","","",
> +       /*H0-H7*/       "","","","","","","","",
> +       /*I0-I7*/       "","","","","","","","",
> +       /*J0-J7*/       "","","checkstop","","","","","",
> +       /*K0-K7*/       "","","","","","","","",
> +       /*L0-L7*/       "","","","","","","","",
> +       /*M0-M7*/       "","","","","","","","",
> +       /*N0-N7*/       "ps1-presence","","rear-fault","rear-power","rear-id","","","",

These last three are LEDs? perhaps we could adopt a convention where
we call them led-<name>.

> +       /*O0-O7*/       "","","","","","","","",
> +       /*P0-P7*/       "","","","","","","","ps0-presence",
> +       /*Q0-Q7*/       "","","","","","","","",
> +       /*R0-R7*/       "","","trans","","","power-button","","",

fsi-trans

> +       /*S0-S7*/       "","","","","","","","",
> +       /*T0-T7*/       "","","","","","","","",
> +       /*U0-U7*/       "","","","","","","","",
> +       /*V0-V7*/       "","","","","","","","",
> +       /*W0-W7*/       "","","","","","","","",
> +       /*X0-X7*/       "","","","","","","","",
> +       /*Y0-Y7*/       "","","","","","","","",
> +       /*Z0-Z7*/       "","","","","","","","",
> +       /*AA0-AA7*/     "clock","","","","","","","",

fsi-clock

> +       /*AB0-AB7*/     "","","","","","","","",
> +       /*AC0-AC7*/     "","","","","","","","";
> +
> +       pin_gpio_a1 {
> +               gpios = <ASPEED_GPIO(A, 1) GPIO_ACTIVE_HIGH>;
> +               output-high;
> +               line-name = "cfam-reset";
> +       };

It think you want to drop this part.

> +
> +};
> +
>  &fmc {
>         status = "okay";
>
> --
> 2.21.0 (Apple Git-122)

You're building kernels on your mac? :D