sdbusplus - const/readonly flags

[Adriana Kobylak]

On 2020-08-25 10:00, Patrick Williams wrote:

>    * I expect some of the 'const' flags in phosphor-dbus-interfaces are
>      wrong and should be changed to 'readonly'.  I have collected a 
> list
>      of them in a gist[4].  If you really intend to mean "this property
>      will never change during the life of an object" continue to use
>      'const', but if you mean "this property shall not be changed by
>      clients", use 'readonly' (and probably also add 'emits_change').

There are also some properties in phosphor-dbus-interfaces with 
descriptions that say "read-only property", and the implementation is 
enforcing it. It may good for the owners to revisit those as well and 
see if a 'read-only' flag is applicable.

> 1.
> https://manpages.debian.org/experimental/libsystemd-dev/SD_BUS_WRITABLE_PROPERTY.3.en.html#Flags
> 2. https://github.com/openbmc/sdbusplus/issues/48
> 3.
> https://github.com/openbmc/sdbusplus/commit/e1c73d3bf8f6cabc1c58f67a233dba55b6f76d74
> 4. 
> https://gist.github.com/williamspatrick/fa975c33f00640ca54a7aa246bbbfeb9