[PATCH linux dev-5.3 1/2] ARM: dts: Add 128MiB OpenBMC flash layout

Joel Stanley joel at jms.id.au
Thu Sep 26 16:32:10 AEST 2019


On Thu, 26 Sep 2019 at 02:31, Brad Bishop <bradleyb at fuzziesquirrel.com> wrote:
>
> This is an alternate layout used by OpenBMC systems.  It describes the
> fixed flash layout for 128MiB devices.
>
> Signed-off-by: Brad Bishop <bradleyb at fuzziesquirrel.com>
> ---
>  .../boot/dts/openbmc-flash-layout-128.dtsi    | 32 +++++++++++++++++++
>  1 file changed, 32 insertions(+)
>  create mode 100644 arch/arm/boot/dts/openbmc-flash-layout-128.dtsi
>
> diff --git a/arch/arm/boot/dts/openbmc-flash-layout-128.dtsi b/arch/arm/boot/dts/openbmc-flash-layout-128.dtsi
> new file mode 100644
> index 000000000000..4e2819a8dac6
> --- /dev/null
> +++ b/arch/arm/boot/dts/openbmc-flash-layout-128.dtsi
> @@ -0,0 +1,32 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +
> +partitions {
> +       compatible = "fixed-partitions";
> +       #address-cells = <1>;
> +       #size-cells = <1>;
> +
> +       u-boot at 0 {
> +               reg = <0x0 0x60000>;

This is 384KB, which is too small for the ast2600 u-boot.

 I suggest we make it 896KB. This is 1MB - 128KB for the environment.

> +               label = "u-boot";
> +       };
> +
> +       u-boot-env at 60000 {
> +               reg = <0x60000 0x20000>;
> +               label = "u-boot-env";
> +       };
> +
> +       kernel at 80000 {
> +               reg = <0x80000 0x780000>;

I suggest we make this bigger. 9MB seems like a nice round number;
that means we end up with 10MB for u-boot + env + FIT.

I will send a patch for review with my proposal.

Cheers,

Joel

> +               label = "kernel";
> +       };
> +
> +       rofs at 800000 {
> +               reg = <0x800000 0x5800000>;
> +               label = "rofs";
> +       };
> +
> +       rwfs at 6000000 {
> +               reg = <0x6000000 0x2000000>;
> +               label = "rwfs";
> +       };
> +};
> --
> 2.21.0


More information about the openbmc mailing list