Re: [PATCH linux dev-5.3 2/6] dt-bindings: net: ftgmac100: Describe clock properties

Andrew Jeffery andrew at aj.id.au
Wed Sep 25 14:19:49 AEST 2019



On Tue, 24 Sep 2019, at 08:50, Vijay Khemka wrote:
> 
> 
> On 9/22/19, 5:40 AM, "openbmc on behalf of Andrew Jeffery" 
> <openbmc-bounces+vijaykhemka=fb.com at lists.ozlabs.org on behalf of 
> andrew at aj.id.au> wrote:
> 
>     Critically, the AST2600 requires ungating the RMII RCLK if e.g. NCSI is
>     in use.
>     
>     Signed-off-by: Andrew Jeffery <andrew at aj.id.au>
>     ---
>      Documentation/devicetree/bindings/net/ftgmac100.txt | 6 ++++++
>      1 file changed, 6 insertions(+)
>     
>     diff --git a/Documentation/devicetree/bindings/net/ftgmac100.txt 
> b/Documentation/devicetree/bindings/net/ftgmac100.txt
>     index 04cc0191b7dd..c443b0b84be5 100644
>     --- a/Documentation/devicetree/bindings/net/ftgmac100.txt
>     +++ b/Documentation/devicetree/bindings/net/ftgmac100.txt
>     @@ -24,6 +24,12 @@ Optional properties:
>      - no-hw-checksum: Used to disable HW checksum support. Here for 
> backward
>        compatibility as the driver now should have correct defaults 
> based on
>        the SoC.
> This is still used for IPV6 as hw checksum for IPV6 packets is still 
> broken in ast2500

I'm not removing it :) I think you've made the same mistake that I've made
in the past and interpreted the '-' as a diff marker rather than the bullet
marker in the text.

Andrew


More information about the openbmc mailing list