[PATCH v3 linux dev-5.3 01/10] dt-bindings: aspeed-lpc: Add G6 compatible strings
Milton Miller II
miltonm at us.ibm.com
Wed Sep 25 09:25:15 AEST 2019
On 09/24/2019 at 02:48PM in some timezone, Brad Bishop wrote:
>Assume everyhing is the same as the AST2500 since the AST2600
>datasheet
>indicates the same register set behind the LPC controller address
>space.
Can we drop everything upto and including since?
>
>Signed-off-by: Brad Bishop <bradleyb at fuzziesquirrel.com>
>---
> v2: new for v2
> v3: move ipmi binding updates to a separate patch
>---
> Documentation/devicetree/bindings/mfd/aspeed-lpc.txt | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
>diff --git a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
>b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
>index 86446074e206..e1197bab57bb 100644
>--- a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
>+++ b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
>@@ -46,6 +46,7 @@ Required properties
> - compatible: One of:
> "aspeed,ast2400-lpc", "simple-mfd"
> "aspeed,ast2500-lpc", "simple-mfd"
>+ "aspeed,ast2600-lpc", "simple-mfd"
>
> - reg: contains the physical address and length values of the
>Aspeed
> LPC memory region.
>@@ -64,6 +65,7 @@ BMC Node
> - compatible: One of:
> "aspeed,ast2400-lpc-bmc"
> "aspeed,ast2500-lpc-bmc"
>+ "aspeed,ast2600-lpc-bmc"
>
> - reg: contains the physical address and length values of the
> H8S/2168-compatible LPC controller memory region
>@@ -74,6 +76,7 @@ Host Node
> - compatible: One of:
> "aspeed,ast2400-lpc-host", "simple-mfd", "syscon"
> "aspeed,ast2500-lpc-host", "simple-mfd", "syscon"
>+ "aspeed,ast2600-lpc-host", "simple-mfd", "syscon"
>
> - reg: contains the address and length values of the host-related
> register space for the Aspeed LPC controller
>@@ -128,6 +131,7 @@ Required properties:
> - compatible: One of:
> "aspeed,ast2400-lpc-ctrl";
> "aspeed,ast2500-lpc-ctrl";
>+ "aspeed,ast2600-lpc-ctrl";
>
> - reg: contains offset/length values of the host interface
>controller
> memory regions
>@@ -168,6 +172,7 @@ Required properties:
> - compatible: One of:
> "aspeed,ast2400-lhc";
> "aspeed,ast2500-lhc";
>+ "aspeed,ast2600-lhc";
>
> - reg: contains offset/length values of the LHC memory regions. In
>the
> AST2400 and AST2500 there are two regions.
>@@ -187,7 +192,8 @@ state of the LPC bus. Some systems may chose to
>modify this configuration.
>
> Required properties:
>
>- - compatible: "aspeed,ast2500-lpc-reset" or
>+ - compatible: "aspeed,ast2600-lpc-reset" or
>+ "aspeed,ast2500-lpc-reset"
> "aspeed,ast2400-lpc-reset"
Minor nit: This one disn't use the phrase "One of" and needs either another
instance of "or", or it needs to adopt the "One of" like the other bindings.
> - reg: offset and length of the IP in the LHC memory region
> - #reset-controller indicates the number of reset cells expected
>--
>2.21.0
>
>
Thanks,
miilton
More information about the openbmc
mailing list