[PATCH linux dev-5.3 2/6] dt-bindings: net: ftgmac100: Describe clock properties

[Joel Stanley]

On Mon, 23 Sep 2019 at 05:14, Andrew Jeffery <andrew at aj.id.au> wrote:
>
>
>
> On Mon, 23 Sep 2019, at 14:28, Joel Stanley wrote:
> > On Sun, 22 Sep 2019 at 12:36, Andrew Jeffery <andrew at aj.id.au> wrote:
> > >
> > > Critically, the AST2600 requires ungating the RMII RCLK if e.g. NCSI is
> > > in use.
> > >
> > > Signed-off-by: Andrew Jeffery <andrew at aj.id.au>
> > > ---
> > >  Documentation/devicetree/bindings/net/ftgmac100.txt | 6 ++++++
> > >  1 file changed, 6 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/net/ftgmac100.txt b/Documentation/devicetree/bindings/net/ftgmac100.txt
> > > index 04cc0191b7dd..c443b0b84be5 100644
> > > --- a/Documentation/devicetree/bindings/net/ftgmac100.txt
> > > +++ b/Documentation/devicetree/bindings/net/ftgmac100.txt
> > > @@ -24,6 +24,12 @@ Optional properties:
> > >  - no-hw-checksum: Used to disable HW checksum support. Here for backward
> > >    compatibility as the driver now should have correct defaults based on
> > >    the SoC.
> > > +- clocks: In accordance with the generic clock bindings. Must describe the MAC
> > > +  IP clock, and optionally an RMII RCLK gate for the AST2600.
> >
> > perhaps: "and optionally a RMII clock if RMII or NC-SI is used"
> >
> > We should implement this for the ast2500 too.
>
> Hmm, I didn't think to check because it has always worked, but I assume that's because u-boot was NCSI enabled and left the clocks ungated.

Yeah spot on. This is something we hit when doing bringup of the
ast2500 NCSI, and we "fixed" it by having u-boot enable the clocks.

>
> Will fix in a v2.

Cheers

>
> Thanks,
>
> Andrew