Re: [PATCH linux dev-5.3 3/6] dt-bindings: clock: Add AST2600 RMII RCLK gate definitions

[Andrew Jeffery]

On Mon, 23 Sep 2019, at 14:28, Joel Stanley wrote:
> On Sun, 22 Sep 2019 at 12:36, Andrew Jeffery <andrew at aj.id.au> wrote:
> >
> > The AST2600 has an explicit gate for the RMII RCLK for each of the four
> > MACs.
> >
> > Signed-off-by: Andrew Jeffery <andrew at aj.id.au>
> 
> Put this in the same patch as the clock driver changes when you respin.

I initially did what you suggested and checkpatch complained. It's explicitly documented that DT header changes should be separate in the dt-specific submitting-patches documentation.

> >
> > +#define ASPEED_CLK_GATE_MAC1RCLK       67
> > +#define ASPEED_CLK_GATE_MAC2RCLK       68
> > +#define ASPEED_CLK_GATE_MAC3RCLK       69
> > +#define ASPEED_CLK_GATE_MAC4RCLK       70
> 
> Nit: You call them MACnCLK here, but rmmin_clk in is the gate name.
> Please pick one and use it in both places.

Ack