code review about phosphor-ipmi-flash

[Patrick Venture]

On Wed, Sep 18, 2019 at 1:13 AM CS20 CTCchien <CTCCHIEN at nuvoton.com> wrote:
>
> Hello Patrick,
>
>
>
> You have a comment in this link about recipes-phosphor/flash/phosphor-software-manager_%.bbappend
>
> https://gerrit.openbmc-project.xyz/c/openbmc/meta-nuvoton/+/25220/2/recipes-phosphor/flash/phosphor-software-manager_%2525.bbappend#1
>
>
>
> do you mean I should use "verify-signature-nuvoton" instead of "verify-signature" ?

No, I'm saying your bbappend file is overriding the PACKAGECONFIG with
a weak default that'll be applied to any machine in a multi-machine
environment that parses that bbappend file.  Your other bbappend does
the same thing.  We use machine or other overrides to safely allow
modifying only select systems.

https://github.com/openbmc/meta-nuvoton/blob/master/conf/machine/include/nuvoton.inc#L6

This is an example of the override.  In this case, if a MACHINE
includes that file, they'll have that override available to them, and
so recipes with

PACKAGECONFIG_nuvoton ... will be picked up, but only for them.

Similarly, all the items in this file:
https://gerrit.openbmc-project.xyz/c/openbmc/meta-nuvoton/+/25220/2/recipes-phosphor/ipmi/phosphor-ipmi-flash_%2525.bbappend

Can be locked by a machine override.

However, from the discussion with Brad, you're going to want to take
the values you're defining, "0xc0008000, 0xF0848000" ... and add them
to the core recipe itself with useful names. Right above this:
https://github.com/openbmc/meta-phosphor/blob/master/recipes-phosphor/ipmi/phosphor-ipmi-flash_git.bb#L38

Then if someone wants to enable a specific nuvoton feature, they
assign IPMI_FLASH_BMC_ADDRESS_theirmachine = NUVOTON_FLASH_PCIVGA ...
or whatever in their bbappend.

>
> Thanks
>
>
>
>
>
> B.R.
>
> Medad
>
> ________________________________
> The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.