[PATCH v2 1/2] dt-binding: hwrng: add NPCM RNG documentation

[Tomer Maimon]

Hi Daniel,

Sorry but I have probably miss it, thanks a lot for your comment

On Tue, 10 Sep 2019 at 13:25, Daniel Thompson <daniel.thompson at linaro.org>
wrote:

> On Mon, Sep 09, 2019 at 03:38:39PM +0300, Tomer Maimon wrote:
> > Added device tree binding documentation for Nuvoton BMC
> > NPCM Random Number Generator (RNG).
> >
> > Signed-off-by: Tomer Maimon <tmaimon77 at gmail.com>
> > ---
> >  .../bindings/rng/nuvoton,npcm-rng.txt           | 17 +++++++++++++++++
> >  1 file changed, 17 insertions(+)
> >  create mode 100644
> Documentation/devicetree/bindings/rng/nuvoton,npcm-rng.txt
> >
> > diff --git a/Documentation/devicetree/bindings/rng/nuvoton,npcm-rng.txt
> b/Documentation/devicetree/bindings/rng/nuvoton,npcm-rng.txt
> > new file mode 100644
> > index 000000000000..a697b4425fb3
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/rng/nuvoton,npcm-rng.txt
> > @@ -0,0 +1,17 @@
> > +NPCM SoC Random Number Generator
> > +
> > +Required properties:
> > +- compatible  : "nuvoton,npcm750-rng" for the NPCM7XX BMC.
> > +- reg         : Specifies physical base address and size of the
> registers.
> > +
> > +Optional property:
> > +- quality : estimated number of bits of true entropy per 1024 bits
> > +                     read from the rng.
> > +                     If this property is not defined, it defaults to
> 1000.
>
> There are pending unreplied review comments about this property (my own
> as it happens):
> https://patchwork.kernel.org/patch/11119371/
>
> No, there isn't different SoCs.
we had checked the quality of the hwrng and the results we got are set as
default.
we been asked from one of our client to have a dynamic quality, they will
like to be more strict when using the hwrng.
is it problematic to add it?

Having a controllable quality implies that the numeric quality of the
peripheral changes when it is stamped out on different SoCs (otherwise
the driver can confidently set the quality without needing any hint
from the DT). Is that really true here?


> Daniel.
>
> > +
> > +Example:
> > +
> > +rng: rng at f000b000 {
> > +     compatible = "nuvoton,npcm750-rng";
> > +     reg = <0xf000b000 0x8>;
> > +};
> > --
> > 2.18.0
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20190910/3c01eef8/attachment.htm>