Re: [PATCH linux dev-5.2 3/5] mmc: sdhci-of-aspeed: Uphold clocks-on post-condition of set_clock()

[Andrew Jeffery]

On Mon, 2 Sep 2019, at 10:08, Joel Stanley wrote:
> On Fri, 30 Aug 2019 at 09:02, Andrew Jeffery <andrew at aj.id.au> wrote:
> >
> > The early-exit didn't seem to matter on the AST2500, but on the AST2600
> > the SD clock genuinely may not be running on entry to
> > aspeed_sdhci_set_clock(). Remove the early exit to ensure we always run
> > sdhci_enable_clk().
> >
> > Signed-off-by: Andrew Jeffery <andrew at aj.id.au>
> 
> I don't quite understand what this was doing in the original patch.
> The fix is good though, I tested it.

What do you mean? You already had questions about it?  Would have been nice
to pipe up at the time if so :D

> 
> Tested-by: Joel Stanley <joel at jms.id.au>

Thanks,

Andrew