Re: [PATCH linux dev-5.2 2/5] mmc: sdhci-of-aspeed: Drop redundant assignment to host->clock

Andrew Jeffery andrew at aj.id.au
Mon Sep 2 10:40:38 AEST 2019



On Mon, 2 Sep 2019, at 10:07, Joel Stanley wrote:
> On Fri, 30 Aug 2019 at 09:02, Andrew Jeffery <andrew at aj.id.au> wrote:
> >
> > host->clock is already managed by sdhci_set_ios().
> >
> > Suggested-by: Ulf Hansson <ulf.hansson at linaro.org>
> > Signed-off-by: Andrew Jeffery <andrew at aj.id.au>
> 
> Reviewed-by: Joel Stanley <joel at jms.id.au>
> 
> I assume this went upstream with a fixes tag?
> 

I haven't sent it yet, was waiting for Adrian to review my v1 upstream
before sending a v2 with this patch included.

Not sure it needs a fixes tag, but there's no reason it shouldn't have one
either. It's just a code cleanup, it doesn't fix a bug.

Andrew


More information about the openbmc mailing list