x86-power-control

[James Feist]

On 10/22/19 12:06 PM, Johnathan Mantey wrote:
> One observation about this method.
> It may not work for the way CI unit tests are presently behaving.
> 
> For phosphorr-networkd, I think, the unit tests insist that everything 
> being tested be Git committed. The copy of the source file will not be. 
> This will prevent the unit test from running. I found this requirement 
> by the unit tests to be an irritant. I would clang-format my source, and 
> commit.  The unit tests would do an automated reformat, causing my 
> commit to be useless.  I'd have to recommit the source one more time to 
> proceed.  It would be nice to eliminate/modify this requirement in the 
> unit tests.

It should be fine in this case because CI would only be running against 
the "default" header file, the modified one would not get introduced in 
the CI path.

> 
> On 10/22/19 11:04 AM, Johnathan Mantey wrote:
>> You may want to delay the copy until the compile step.  For example:
>>
>> PROJECT_SRC_DIR := "${THISDIR}/${PN}"
>> do_compile_prepend(){
>>     cp -f ${PROJECT_SRC_DIR}/your-header.hpp ${S}
>> }
>>> Don't patch, simply copy over your new header into the correct 
>>> directory in a do_configure_prepend (I think that's the right yocto 
>>> step to overwrite, but I might be off). --
>> Johnathan Mantey
>> Senior Software Engineer
>> *azad te**chnology partners*
>> Contributing to Technology Innovation since 1992
>> Phone: (503) 712-6764
>> Email: johnathanx.mantey at intel.com <mailto:johnathanx.mantey at intel.com>
>>
> 
> -- 
> Johnathan Mantey
> Senior Software Engineer
> *azad te**chnology partners*
> Contributing to Technology Innovation since 1992
> Phone: (503) 712-6764
> Email: johnathanx.mantey at intel.com <mailto:johnathanx.mantey at intel.com>
>