Questions about openbmc-test-automation

[Rahul Maheshwari]

Thanks for pointing that out. Passing interface/channel number is an easier
option but we should be avoiding passing environment variable unless there
is no other way. I would say better way to overcome this is to figure out
the channel count using "ip addr" command from BMC cli.
Let us know if that sounds good to you.
Also let us know if you would like to drop code change for the same?

Thanks
Rahul






On Tue, Nov 5, 2019 at 2:28 PM Tony Lee (李文富) <Tony.Lee at quantatw.com> wrote:

> Hi Rahul,
>
>
>
> I'm wondering that why "REDFISH_NW_ETH0" is hardcode as
> "Managers/bmc/EthernetInterfaces/eth0/" in /data/variables.py
>
>
> https://github.com/openbmc/openbmc-test-automation/blob/master/data/variables.py#L155
>
> Furthermore, the command "lan print" didn't specify the channel number in
> /ipmi/test_ipmi_network.robot.
>
> Therefore, the default will print information on the first found LAN
> channel.
>
>
>
> Isn't it more reasonable to set the interface and the channel number as
> environment variables and give them default values?
>
>
>
> Thanks
>
> Best Regards,
>
> Tony
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20191105/b15711a1/attachment.htm>