Questions about openbmc-test-automation

[Tony Lee (李文富)]

Hi Rahul,

I'm wondering that why "REDFISH_NW_ETH0" is hardcode as "Managers/bmc/EthernetInterfaces/eth0/" in /data/variables.py
https://github.com/openbmc/openbmc-test-automation/blob/master/data/variables.py#L155
Furthermore, the command "lan print" didn't specify the channel number in /ipmi/test_ipmi_network.robot.
Therefore, the default will print information on the first found LAN channel.

Isn't it more reasonable to set the interface and the channel number as environment variables and give them default values?

Thanks
Best Regards,
Tony

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20191105/1fa7731b/attachment.htm>