[PATCH linux dev-5.3 v2 4/8] fsi: move defines to common header

[Joel Stanley]

On Fri, 1 Nov 2019 at 03:17, Jeremy Kerr <jk at ozlabs.org> wrote:
>
> Hi Joel,
>
> > The FSI master registers are common to the hub and AST2600 master (and
> > the FSP2, if someone was to upstream a driver for that).
> >
> > Add defines to the fsi-master.h header, and introduce headings to
> > delineate the existing low level details.
>
> I'm in two minds about this - it's a specific hardware master
> implementation, while fsi-master.h is for the generic core API.

It's a bit messy already, as a bunch of the defines in there are for
the soft FSI drivers. I could create two new headers, one for the soft
masters, and one for the hardware ones.

> That said, it's probably neater than introducing a new header here, so:
>
> Acked-by: Jeremy Kerr <jk at ozlabs.org>
>
> Maybe a potential future change: a unified driver that handles this
> common hardware, just with different register interface implementations?

That would be cool. It would also make it less work to do a FSP driver.

Thanks for the review.