[PATCH linux dev-5.3 v2 4/8] fsi: move defines to common header
Jeremy Kerr
jk at ozlabs.org
Fri Nov 1 14:17:03 AEDT 2019
Hi Joel,
> The FSI master registers are common to the hub and AST2600 master (and
> the FSP2, if someone was to upstream a driver for that).
>
> Add defines to the fsi-master.h header, and introduce headings to
> delineate the existing low level details.
I'm in two minds about this - it's a specific hardware master
implementation, while fsi-master.h is for the generic core API.
That said, it's probably neater than introducing a new header here, so:
Acked-by: Jeremy Kerr <jk at ozlabs.org>
Maybe a potential future change: a unified driver that handles this
common hardware, just with different register interface implementations?
Cheers,
Jeremy
More information about the openbmc
mailing list