[PATCH linux dev-5.3 v2 1/8] fsi: aspeed: Implement byte and half word writes

[Joel Stanley]

On Fri, 1 Nov 2019 at 03:09, Jeremy Kerr <jk at ozlabs.org> wrote:
>
> Hi Joel,
>
> > The driver did not previously support non-word size transfers. The
> > fsi-i2c driver attempts accesses of this size, so we require it now.
> >
> > This creates three functions for doing word, half word and byte
> > writes. This was done to avoid having to decide which length the
> > transfer was twice: both in aspeed_master_write to determine how much
> > of the void * to copy, and again in opb_write to look up the opcode.
>
> Looks good. I was wondering about doing only the writes in this format,
> but then I saw patch 2/8 (would it make sense to combine these?).

I was wondering at what point we merge this driver upstream, and if
it's worthwhile keeping the history.

The major pending TODO is error handling.

>
> Regardless:
>
> Acked-by: Jeremy Kerr <jk at ozlabs.org>
>
> Cheers,
>
>
> Jeremy
>