[PATCH linux dev-5.3 v2 1/8] fsi: aspeed: Implement byte and half word writes

Jeremy Kerr jk at ozlabs.org
Fri Nov 1 14:09:50 AEDT 2019


Hi Joel,

> The driver did not previously support non-word size transfers. The
> fsi-i2c driver attempts accesses of this size, so we require it now.
> 
> This creates three functions for doing word, half word and byte
> writes. This was done to avoid having to decide which length the
> transfer was twice: both in aspeed_master_write to determine how much
> of the void * to copy, and again in opb_write to look up the opcode.

Looks good. I was wondering about doing only the writes in this format,
but then I saw patch 2/8 (would it make sense to combine these?).

Regardless:

Acked-by: Jeremy Kerr <jk at ozlabs.org>

Cheers,


Jeremy



More information about the openbmc mailing list