[PATCH linux dev-5.0 v1] ARM: dts: aspeed: Add SGPIO driver

[Joel Stanley]

Hello,

On Thu, 30 May 2019 at 19:16, Hongwei Zhang <hongweiz at ami.com> wrote:
>
> Add SGPIO driver support for Aspeed AST2500 board.
>
> Signed-off-by: Hongwei Zhang <hongweiz at ami.com>

Thanks for the patch!

Lets get this reviewed upstream and once we've had some feedback there
we can add it to the openbmc tree.

You will need to send out three different patch sets. The first should
be pinmux, which will contain one patch to the device tree, and
another to the driver.

The second should be the sgpio driver. In addition to the C code, you
need to provide a patch with some device tree bindings in
Documentation/devicetree/bindings.

The third patchset should be the change to add sgpio to the device
tree. I suggest you hold off on sending that until the device tree
bindings have been reviewed.

Please use scripts/get_maintainers.pl to discover who to send the
patches to. If you have any questions then please ask.

> ---
>  arch/arm/boot/dts/aspeed-g5.dtsi           |  16 +
>  drivers/gpio/Kconfig                       |   8 +
>  drivers/gpio/Makefile                      |   1 +
>  drivers/gpio/sgpio-aspeed.c                | 644 +++++++++++++++++++++++++++++
>  drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c |   4 +
>  5 files changed, 673 insertions(+)
>  create mode 100644 drivers/gpio/sgpio-aspeed.c

> +++ b/drivers/gpio/sgpio-aspeed.c
> @@ -0,0 +1,644 @@
> +// SPDX-License-Identifier: GPL-2.0

Put another line here with the copyright owner. For example:

// Copyright 2019 Joel's Awesome BMC Company, inc

> +
> +/*
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License
> + * as published by the Free Software Foundation; either version
> + * 2 of the License, or (at your option) any later version.
> + */

If you have the "SPDX" line above you can leave this text out.
However, there's a contradiction: the SPDX text says "GPL 2.0 only",
while this text says "GPL 2.0 or later". You need to clarify which one
you meant.