[PATCH] ARM: dts: aspeed: Add Swift BMC machine

[Joel Stanley]

Hi Adriana,

On Tue, 12 Mar 2019 at 21:47, Matt Spinler <mspinler at linux.ibm.com> wrote:
> On 3/5/2019 3:07 PM, Adriana Kobylak wrote:
> > The Swift BMC is an ASPEED ast2500 based BMC that is part of
> > a Power9 server. This adds the device tree description for
> > most upstream components.
> > There's a pending TODO to create the flash layout for its
> > 16GB NAND flash chip. Use the default 32MB NOR flash chip
> > for this initial commit.

> > +     max31785 at 52 {
> > +             compatible = "maxim,max31785a";
> > +             reg = <0x52>;
> > +             #address-cells = <1>;
> > +             #size-cells = <0>;
> > +
> > +             fan at 0 {
> > +                     compatible = "pmbus-fan";
> > +                     reg = <0>;
> > +                     tach-pulses = <2>;
> > +                     maxim,fan-rotor-input = "tach";
> > +                     maxim,fan-pwm-freq = <25000>;
> > +                     maxim,fan-dual-tach;
>
>
> The 4 main fans are single rotor, so you don't need the fan-dual-tach
> line on them.
>
> I'm not sure about that booster fan though.

Are you going to send a v2 that address Matt's comment?

>
>
> > +                     maxim,fan-no-watchdog;
> > +                     maxim,fan-no-fault-ramp;
> > +                     maxim,fan-ramp = <2>;
> > +                     maxim,fan-fault-pin-mon;
> > +             };