IPMI Add SEL command question

[Bills, Jason M]

On 7/12/2019 12:07 PM, Emily Shaffer wrote:
> Harry, I suggest that you participate in the discussion on the review 
> you linked to give suggestions. You're right that it's not implemented - 
> if you have a vested interest in it, your best bet is to find out what 
> approach Jason etc. took and see if you can help fix the problems they 
> found in your own implementation. Based on the inactivity there, I'm 
> guessing Intel deprioritized that command, so you should probably expect 
> to drive development effort (or modification of that patch) yourself. >
> On Fri, Jul 12, 2019 at 7:08 AM Harry Sung1 <hsung1 at lenovo.com 
> <mailto:hsung1 at lenovo.com>> wrote:
> 
>     Hi Team,____
> 
>     __ __
> 
>     I have a question about Add SEL command. __ __
> 
>     This standard command seems not be implemented in
>     “phosphor-host-ipmid”.____
> 
>     (https://github.com/openbmc/phosphor-host-ipmid/blob/master/storagehandler.cpp#L605)____
> 
>     __ __
> 
>     Though I found a patch set about it, but it doesn’t be merged in
>     master due to some issues.____
> 
>     https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-host-ipmid/+/12951____
> 
This change ran into issues when we persisted the journal to flash. 
Because of that, Intel has moved to keeping the journal only in volatile 
memory and using rsyslog to scrape the SEL entries from the journal and 
persist them in a text file which is much more efficient.

We have also moved away from allowing the Add SEL command to go into the 
IPMI SEL because we currently only support dynamic IPMI sensor numbers. 
We still support the Add SEL command but it adds a "Raw SEL" entry to 
the Redfish log instead of IPMI SEL.  However, if the sensor numbers are 
not an issue, the old Add SEL implementation in review should still work.

Our current implementation is here: 
https://github.com/openbmc/intel-ipmi-oem/blob/master/src/storagecommands.cpp.

If there is interest in making the journal+rsyslog SEL implementation 
available as a build option, I can update this review.  Otherwise, it 
may be time to abandon it.

>     __ __
> 
>     Is anyone having any plans to implement it? Or other repository we
>     can refer to?____
> 
>     __ __
> 
>     Thanks,____
> 
>     Harry____
> 
> 
> 
> -- 
> Emily Shaffer