[RFC v2 dev-5.1 4/5] i2c: aspeed: add buffer mode transfer support

Jae Hyun Yoo jae.hyun.yoo at linux.intel.com
Wed Jul 3 02:05:42 AEST 2019


On 7/1/2019 10:24 PM, Joel Stanley wrote:
> On Thu, 27 Jun 2019 at 23:35, Jae Hyun Yoo <jae.hyun.yoo at linux.intel.com> wrote:
>>
>> On 6/27/2019 4:24 PM, Tao Ren wrote:
>>> On 6/25/19 1:51 PM, Jae Hyun Yoo wrote:
>>>> Byte mode currently this driver uses makes lots of interrupt call
>>>> which isn't good for performance and it makes the driver very
>>>> timing sensitive. To improve performance of the driver, this commit
>>>> adds buffer mode transfer support which uses I2C SRAM buffer
>>>> instead of using a single byte buffer.
>>>>
>>>> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo at linux.intel.com>
>>>
>>> Tested-by: Tao Ren <taoren at fb.com>
>>>
>>> Applied patch serial 1-4 to openbmc kernel 5.1.15 and booted up Facebook CMM AST2500 BMC: I2C component looks normal to me.
>>
>> Hi Tao,
>>
>> Thanks a lot for sharing the test result.
> 
> Do you want we to merge this series into the openbmc tree for further testing?

Hi Joel,

Yes please. It would be good if it gets tested on more various platforms
before upstreaming it.

Thanks,
Jae

> Cheers,
> 
> Joel
> 
>>
>> Regards,
>> Jae
>>
>>>
>>> Cheers,
>>>
>>> Tao
>>>


More information about the openbmc mailing list