[PATCH v2 1/2] dt-binding: iio: add NPCM ADC documentation
Joel Stanley
joel at jms.id.au
Wed Jan 16 10:21:30 AEDT 2019
On Thu, 10 Jan 2019 at 03:44, Tomer Maimon <tmaimon77 at gmail.com> wrote:
> +Required Node in the NPCM7xx BMC:
> +An additional register is present in the NPCM7xx SOC which is
> +assumed to be in the same device tree, with and marked as
> +compatible with "nuvoton,npcm750-rst".
Is there a reason you don't include a phandle to the reset node?
I think doing that would make more sense.
> +adc: adc at f000c000 {
> + compatible = "nuvoton,npcm750-adc";
> + reg = <0xf000c000 0x8>;
> + interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clk NPCM7XX_CLK_ADC>;
> +};
> +
> +rst: rst at f0801000 {
> + compatible = "nuvoton,npcm750-rst", "syscon",
> + "simple-mfd";
> + reg = <0xf0801000 0x6C>;
> +};
More information about the openbmc
mailing list