Re-use witherspoon-psu-monitor

Matt Spinler mspinler at linux.ibm.com
Wed Aug 14 04:22:07 AEST 2019



On 8/12/2019 3:54 AM, George Liu (刘锡伟) wrote:
> Hi All,
>
> Recently I need to get the asset information of psu on the fp5280g2 machine. For the downstream, I think re-use witherspoon-psu-monitor is better. but currently it`s only adapted witherspoon machine.Is it possible to change this recipes to a general repo, so that a repo can be adapted to a variety of machines for future maintenance and updates?

Sounds like a good idea to me!  The only reason we put a witherspoon on 
the repo name in  the first place was because we didn't know how others 
would want to do PSU interaction at that time and we didn't want to 
presume that we should be a generic repo for it.

>
> I have a couple of question:
>
> 1. For the recipes of the witherspoon-psu-monitor, could it be changed to a generic name, for example...

Yea, we would definitely want to change the recipe name if we change the 
repo name.

>
> 2. When reading and updating the properties of the xyz.openbmc_project.Inventory.Decorator.Asset interface via the pmbus driver, could it be changed to a common configuration (eg yaml or json, etc.)

I'm not exactly sure what you're looking to do, but if the goal is to 
make it more generic, I'm all for it.  I have no problem with making 
things configurable.

>
> 3. /sys/kenerl/debug/pmbus/hwmonX/XXX/... Does each file name need to be unified?

If you're suggesting adding some configurable way of specifying which 
sysfs files to read, that also sounds like a good idea.

>
> Thanks!



More information about the openbmc mailing list