[PATCH v4 4/4] ARM: dts: aspeed: Add Mihawk BMC platform
Milton Miller II
miltonm at us.ibm.com
Sat Aug 10 02:28:18 AEST 2019
Hi Joel, and Ben.
On 08/09/2019 around 01:59AM in some timezone, Joel Stanley wrote:>Hi Ben,
>
>On Wed, 7 Aug 2019 at 14:47, Ben Pai <Ben_Pai at wistron.com> wrote:
>>> +&fmc {
>> + status = "okay";
>> + flash at 0 {
>
>There is no reg property so I think the @0 is incorrect.
The reg property is in the aspeed-g5.dtsi and the @0 is correct.
The layout is shared with witherspoon and the capacity matches.
Perhaps we should create a openbmc-ubi-32m.dtsi
similar to openbmc-flash-layout.dtsi.
>>> + status = "okay";
>> + label = "bmc";
>> + m25p,fast-read;
>> + spi-max-frequency = <50000000>;
>> + partitions {
>> + #address-cells = < 1 >;
>> + #size-cells = < 1 >;
>> + compatible = "fixed-partitions";
>> + u-boot at 0 {
>> + reg = < 0 0x60000 >;
>> + label = "u-boot";
>> + };
>> + u-boot-env at 60000 {
>> + reg = < 0x60000 0x20000 >;
>> + label = "u-boot-env";
>> + };
>> + obmc-ubi at 80000 {
>> + reg = < 0x80000 0x1F80000 >;
>> + label = "obmc-ubi";
>> + };
>> + };
>> + };
>> + flash at 1 {
>
>as above.
as above.
>
>> + status = "okay";
>> + label = "alt-bmc";
>> + m25p,fast-read;
>> + spi-max-frequency = <50000000>;
This would need a second include for the alt- labels.
>> + partitions {
>> + #address-cells = < 1 >;
>> + #size-cells = < 1 >;
>> + compatible = "fixed-partitions";
>> + u-boot at 0 {
>> + reg = < 0 0x60000 >;
>> + label = "alt-u-boot";
>> + };
>> + u-boot-env at 60000 {
>> + reg = < 0x60000 0x20000 >;
>> + label = "alt-u-boot-env";
>> + };
>> + obmc-ubi at 80000 {
>> + reg = < 0x80000 0x1F80000 >;
>> + label = "alt-obmc-ubi";
>> + };
>> + };
>> + };
>> +};
>> +
>> +&spi1 {
>> + status = "okay";
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_spi1_default>;
>> +
>> + flash at 0 {
>
>as above.
here too, reg is in dtsi along with compatible.
>>> + status = "okay";
>> + label = "pnor";
>> + m25p,fast-read;
>> + spi-max-frequency = <100000000>;
>> + };
>> +};
>
milton
More information about the openbmc
mailing list