[PATCH v2 2/2] spi: npcm-fiu: add NPCM FIU controller driver

[Tomer Maimon]

Hi Boris,

Thanks a lot for your comment.

On Thu, 8 Aug 2019 at 18:32, Boris Brezillon <boris.brezillon at collabora.com>
wrote:

> On Thu,  8 Aug 2019 16:14:48 +0300
> Tomer Maimon <tmaimon77 at gmail.com> wrote:
>
>
> > +
> > +static const struct spi_controller_mem_ops npcm_fiu_mem_ops = {
> > +     .exec_op = npcm_fiu_exec_op,
>
> No npcm_supports_op()? That's suspicious, especially after looking at
> the npcm_fiu_exec_op() (and the functions called from there) where the
> requested ->buswidth seems to be completely ignored...
>
> Sorry but I do not fully understand it, do you mean a support for the
buswidth?
If yes it been done in the UMA functions as follow:

                uma_cfg |= ilog2(op->cmd.buswidth);
                uma_cfg |= ilog2(op->addr.buswidth) <<
                        NPCM_FIU_UMA_CFG_ADBPCK_SHIFT;
                uma_cfg |= ilog2(op->data.buswidth) <<
                        NPCM_FIU_UMA_CFG_WDBPCK_SHIFT;
                uma_cfg |= op->addr.nbytes << NPCM_FIU_UMA_CFG_ADDSIZ_SHIFT;
                regmap_write(fiu->regmap, NPCM_FIU_UMA_ADDR, op->addr.val);

> +     .dirmap_create = npcm_fiu_dirmap_create,
> > +     .dirmap_read = npcm_fiu_direct_read,
> > +     .dirmap_write = npcm_fiu_direct_write,
> > +};
> > +
>

Thanks,

Tomer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20190809/6f19e1f8/attachment.htm>