<div dir="ltr"><div dir="ltr"><br></div>Hi Boris,<div><br></div><div>Thanks a lot for your comment.</div><div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, 8 Aug 2019 at 18:32, Boris Brezillon <<a href="mailto:boris.brezillon@collabora.com">boris.brezillon@collabora.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Thu,  8 Aug 2019 16:14:48 +0300<br>
Tomer Maimon <<a href="mailto:tmaimon77@gmail.com" target="_blank">tmaimon77@gmail.com</a>> wrote:<br>
<br>
<br>
> +<br>
> +static const struct spi_controller_mem_ops npcm_fiu_mem_ops = {<br>
> +     .exec_op = npcm_fiu_exec_op,<br>
<br>
No npcm_supports_op()? That's suspicious, especially after looking at<br>
the npcm_fiu_exec_op() (and the functions called from there) where the<br>
requested ->buswidth seems to be completely ignored...<br>
<br></blockquote><div>Sorry but I do not fully understand it, do you mean a support for the buswidth?</div><div>If yes it been done in the UMA functions as follow:</div><div><div style="font-family:"Courier New";font-size:11pt;color:rgb(0,0,0)">
<pre>                uma_cfg |= <span style="font-weight:bolder">ilog2</span>(op->cmd.buswidth);
                uma_cfg |= <span style="font-weight:bolder">ilog2</span>(op->addr.buswidth) <<
                        NPCM_FIU_UMA_CFG_ADBPCK_SHIFT;
                uma_cfg |= <span style="font-weight:bolder">ilog2</span>(op->data.buswidth) <<
                        NPCM_FIU_UMA_CFG_WDBPCK_SHIFT;
                uma_cfg |= op->addr.nbytes << NPCM_FIU_UMA_CFG_ADDSIZ_SHIFT;
                <span style="font-weight:bolder">regmap_write</span>(fiu->regmap, NPCM_FIU_UMA_ADDR, op->addr.val);
</pre></div></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
> +     .dirmap_create = npcm_fiu_dirmap_create,<br>
> +     .dirmap_read = npcm_fiu_direct_read,<br>
> +     .dirmap_write = npcm_fiu_direct_write,<br>
> +};<br>
> +<br></blockquote><div><br></div><div>Thanks,</div><div><br></div><div>Tomer </div></div></div></div>