[HELP] ipmi-kcs didn't work

[Samuel Jiang]

Hi Jae,

We also encountered the same situation a month ago.
We try to enable the LPC clock on devicetree to resolve this problem not direct modify clock driver.

lpc_ctrl: lpc-ctrl at 0 {
  compatible = "aspeed,ast2500-lpc-ctrl”;
  reg = <0x0 0x80>;
  clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
    status = “okay”;
};

However, I’m not sure which is better for LPC_CLCK setting.
Whether we should modify driver if original data is enabled or should enable on the device tree, correct?


Thanks,

Samuel Jiang
On Nov 30, 2018, 2:58 AM +0800, Jae Hyun Yoo <jae.hyun.yoo at linux.intel.com>, wrote:
> On 11/29/2018 12:42 PM, Vijay Khemka wrote:
> > Try below fix on clk-aspeed.c
> >
> > diff --git a/drivers/clk/clk-aspeed.c b/drivers/clk/clk-aspeed.c
> > index 596136793fc4..b55d35e3eb5e 100644
> > --- a/drivers/clk/clk-aspeed.c
> > +++ b/drivers/clk/clk-aspeed.c
> > @@ -95,7 +95,7 @@ static const struct aspeed_gate_data aspeed_gates[] = {
> > [ASPEED_CLK_GATE_DCLK] = { 5, -1, "dclk-gate",
> > NULL, CLK_IS_CRITICAL }, /* DAC */
> > [ASPEED_CLK_GATE_REFCLK] = { 6, -1, "refclk-gate",
> > "clkin", CLK_IS_CRITICAL },
> > [ASPEED_CLK_GATE_USBPORT2CLK] = { 7, 3, "usb-port2-gate",
> > NULL, 0 }, /* USB2.0 Host port 2 */
> > - [ASPEED_CLK_GATE_LCLK] = { 8, 5, "lclk-gate",
> > NULL, 0 }, /* LPC */
> > + [ASPEED_CLK_GATE_LCLK] = { 8, 5, "lclk-gate",
> > NULL, CLK_IS_CRITICAL }, /* LPC */
> > [ASPEED_CLK_GATE_USBUHCICLK] = { 9, 15, "usb-uhci-gate",
> > NULL, 0 }, /* USB1.1 (requires port 2 enabled) */
> > [ASPEED_CLK_GATE_D1CLK] = { 10, 13, "d1clk-gate",
> > NULL, 0 }, /* GFX CRT */
> > [ASPEED_CLK_GATE_YCLK] = { 13, 4, "yclk-gate",
> > NULL, 0 }, /* HAC */
> >
> > In my experiments on my system, LCLK was not enabled due to the null
> > parent dependency so I added CLK_IS_CRITICAL flag to enable the clk.
> >
> > LPC interface is default pin pad setting of AST2500 so you might not
> > need a pinctrl setting on it if you didn't change it's pin pads to GPIO
> > or eSPI.
> >
> > Cheers,
> > Jae
> >
> > Jae,
> > Are you planning to upstream this patch as it is needed for kcsbridge to work. Also aspeed-g5 dtsi file.
>
> Okay, I'll submit this patch and dtsi patch to community.
>
> Thanks,
> Jae
>
> >
> > Regards
> > -Vijay
> >
> >
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20181130/000818c7/attachment.html>