<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<title></title>
</head>
<body>
<div name="messageBodySection" style="font-size: 14px; font-family: -apple-system, BlinkMacSystemFont, sans-serif;">Hi Jae,
<div><br /></div>
<div>
<div>We also encountered the same situation a month ago.<br />
We try to enable the LPC clock on devicetree to resolve this problem not direct modify clock driver.<br /></div>
<div><br /></div>
<div>lpc_ctrl: lpc-ctrl@0 { </div>
<div> compatible = "aspeed,ast2500-lpc-ctrl”; </div>
<div> reg = <0x0 0x80>; </div>
<div> clocks = <&syscon ASPEED_CLK_GATE_LCLK>; </div>
<div> status = “okay”; </div>
<div>};</div>
</div>
<div><br /></div>
<div>However, I’m not sure which is better for LPC_CLCK setting.<br /></div>
<div>Whether we should modify driver if original data is enabled or should enable on the device tree, correct?<br /></div>
<div><br /></div>
</div>
<div name="messageSignatureSection" style="font-size: 14px; font-family: -apple-system, BlinkMacSystemFont, sans-serif;"><br />
Thanks,
<div><br /></div>
<div>Samuel Jiang</div>
</div>
<div name="messageReplySection" style="font-size: 14px; font-family: -apple-system, BlinkMacSystemFont, sans-serif;">On Nov 30, 2018, 2:58 AM +0800, Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>, wrote:<br />
<blockquote type="cite" style="margin: 5px 5px; padding-left: 10px; border-left: thin solid #1abc9c;">On 11/29/2018 12:42 PM, Vijay Khemka wrote:<br />
<blockquote type="cite" style="margin: 5px 5px; padding-left: 10px; border-left: thin solid #e67e22;">Try below fix on clk-aspeed.c<br />
<br />
diff --git a/drivers/clk/clk-aspeed.c b/drivers/clk/clk-aspeed.c<br />
index 596136793fc4..b55d35e3eb5e 100644<br />
--- a/drivers/clk/clk-aspeed.c<br />
+++ b/drivers/clk/clk-aspeed.c<br />
@@ -95,7 +95,7 @@ static const struct aspeed_gate_data aspeed_gates[] = {<br />
[ASPEED_CLK_GATE_DCLK] = { 5, -1, "dclk-gate",<br />
NULL, CLK_IS_CRITICAL }, /* DAC */<br />
[ASPEED_CLK_GATE_REFCLK] = { 6, -1, "refclk-gate",<br />
"clkin", CLK_IS_CRITICAL },<br />
[ASPEED_CLK_GATE_USBPORT2CLK] = { 7, 3, "usb-port2-gate",<br />
NULL, 0 }, /* USB2.0 Host port 2 */<br />
- [ASPEED_CLK_GATE_LCLK] = { 8, 5, "lclk-gate",<br />
NULL, 0 }, /* LPC */<br />
+ [ASPEED_CLK_GATE_LCLK] = { 8, 5, "lclk-gate",<br />
NULL, CLK_IS_CRITICAL }, /* LPC */<br />
[ASPEED_CLK_GATE_USBUHCICLK] = { 9, 15, "usb-uhci-gate",<br />
NULL, 0 }, /* USB1.1 (requires port 2 enabled) */<br />
[ASPEED_CLK_GATE_D1CLK] = { 10, 13, "d1clk-gate",<br />
NULL, 0 }, /* GFX CRT */<br />
[ASPEED_CLK_GATE_YCLK] = { 13, 4, "yclk-gate",<br />
NULL, 0 }, /* HAC */<br />
<br />
In my experiments on my system, LCLK was not enabled due to the null<br />
parent dependency so I added CLK_IS_CRITICAL flag to enable the clk.<br />
<br />
LPC interface is default pin pad setting of AST2500 so you might not<br />
need a pinctrl setting on it if you didn't change it's pin pads to GPIO<br />
or eSPI.<br />
<br />
Cheers,<br />
Jae<br />
<br />
Jae,<br />
Are you planning to upstream this patch as it is needed for kcsbridge to work. Also aspeed-g5 dtsi file.<br /></blockquote>
<br />
Okay, I'll submit this patch and dtsi patch to community.<br />
<br />
Thanks,<br />
Jae<br />
<br />
<blockquote type="cite" style="margin: 5px 5px; padding-left: 10px; border-left: thin solid #e67e22;"><br />
Regards<br />
-Vijay<br />
<br />
<br /></blockquote>
</blockquote>
<div></div>
</div>
</body>
</html>