[RFC PATCH linux dev-4.13 1/3] soc: aspeed: Miscellaneous control interfaces

[Andrew Jeffery]

Hi Eugene,

On Wed, 2 May 2018, at 02:51, Eugene.Cho at dell.com wrote:
> 
> >> An observation: It's the only thing inside this file that is aspeed 
> >> specific. If not for the name, it could be generic code.
> 
> >I agree, hence some of the bullet points in the cover letter. But it's name and location was also partly driven by Arnd's suggestion that we stick the junk in drivers/soc, and it felt a bit weird not to use aspeed in the name >given the convention there.
> 
> Just FYI - We've got the same exact problem on Nuvoton (just odds and 
> ends in misc registers). Does this imply we will need a soc/npcm750 
> which also does the exact same thing?

I don't think so, if anything it's an argument for moving it out of soc/aspeed

> 
> I'm guessing making it too generic - will make it harder to get upstream?
> 

Probably, but the more evidence we have for requiring it the harder it is to argue against, and so the fact that this could help the NPCM as well might even make it easier to upstream.

Have you played with the implementation at all? Would be good to get some consensus on it being a decent approach here before we go upstream with it. I also need to add devicetree bindings and ABI documentation...

Cheers,

Andrew