Feature request in phosphor-pid-control

Brad Bishop bradleyb at fuzziesquirrel.com
Fri Jun 15 04:36:20 AEST 2018


> 
> On Jun 14, 2018, at 1:21 PM, Tanous, Ed <ed.tanous at intel.com> wrote:
> 
> So far as I know, no one has proposed one of these yet, but I would happily help review a patch.

I’m pretty sure Matt Barth added support for xyz.openbmc_project.State.Decorator.OperationalStatus
to phosphor-hwmon already.  It certainly doesn’t cover something like mapper timeouts though (nor
should it, IMO).

> 
> Also, (not Patrick) I would support a parameter in phosphor-pid-control that makes sensors optional.  The only part that worries me here is that there is a big difference at a system level between "unavailable" and "faulted", but I think that could be easily fixed in a future patchset if we get the full DBus support for status interfaces.
> 
> -Ed


More information about the openbmc mailing list