[PATCH linux dev-4.13 v5] Add ARM system BMC device tree

ChenKenYY 陳永營 TAO chen.kenyy at inventec.com
Wed Feb 21 17:00:15 AEDT 2018


Hi Joel,

2018-02-16 10:16 GMT+08:00 Joel Stanley <joel at jms.id.au>:
> On Fri, Feb 16, 2018 at 12:40 PM, Joel Stanley <joel at jms.id.au> wrote:
>> Hi Ken,
>>
>> On Mon, Feb 12, 2018 at 10:40 PM, Ken Chen <chen.kenyy at inventec.com> wrote:
>>> Centriq2400-rep is ARM system reference evalutiion platform
>>> with ast2520 BMC.
>>
>> How about:
>>
>> The Qualcomm Centriq 2400 REP (Reference Evaluation Platform) is
>> aarch64 Armv8 server platform with an ast2520 BMC.
>>
OK!
>>
>>>
>>> Signed-off-by: Ken Chen <chen.kenyy at inventec.com>
>>>
>>> ---
>>> v4->v5
>>> - Removed strange whitespace
>>> - Removed aspeed.c commit
>>> - Modify commit content
>>>
>>> v3->v4
>>> - Modify Makefile for centriq2400-rep dts
>>> - Fix typo label
>>> - Removed unnecessary define of spi2 and centriq2400-spi-hwmon device
>>> - Removed lpc device
>>> - Fix coding style
>>> - Removed ssif device
>>> - Removed max31790 device
>>> - Removed register control of GPIO and Watchdog
>>> ---
>>>  arch/arm/boot/dts/Makefile                         |   1 +
>>>  .../boot/dts/aspeed-bmc-arm-centriq2400-rep.dts    | 276 +++++++++++++++++++++
>>>  2 files changed, 277 insertions(+)
>>>  create mode 100644 arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dts
>>>
>>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>>> index 7c54fc8..77aef19 100644
>>> --- a/arch/arm/boot/dts/Makefile
>>> +++ b/arch/arm/boot/dts/Makefile
>>> @@ -993,6 +993,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += aspeed-bmc-opp-palmetto.dtb \
>>>         aspeed-bmc-mellanox-msn.dtb \
>>>         aspeed-bmc-quanta-q71l.dtb \
>>>         aspeed-bmc-intel-s2600wf.dtb \
>>> +        aspeed-bmc-arm-centriq2400-rep.dtb \
>>
>> Nit: we keep these in alphabetical order.
>>
>> I notice that this patch is against the 4.10 branch. Please rebase
>> your patch on dev-4.13.
OK
>>
>>>         aspeed-ast2500-evb.dtb
>>>  endif
>>>
>>
>>> +&gpio {
>>> +       pin_gpio_c7 {
>>> +               gpio-hog;
>>> +               gpios = <ASPEED_GPIO(C, 7) GPIO_ACTIVE_HIGH>;
>>> +               output;
>>> +               line-name = "BIOS_SPI_MUX_S";
>>> +       };
>>> +}

here miss a ";".
I will fix it.
>>
>> Have you built and booted a kernel using this device tree?
>>
>> I get an error when building:
>>
>> Error: arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dts:276.2-277.1
>> syntax error
>> FATAL ERROR: Unable to parse input tree
>>
>> Please fix up the missing semicolon, do a build, and ensure this boots
>> on your system.
>
> Please take a look at these warnings too:
>
>   DTC     arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dtb
> arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dtb: Warning
> (reg_format): "reg" property in
> /ahb/apb/i2c at 1e78a000/i2c-bus at 40/pca9542 at 70/i2c at 0 has invalid length
> (4 bytes) (#address-cells == 2, #size-cells == 1)
> arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dtb: Warning
> (reg_format): "reg" property in
> /ahb/apb/i2c at 1e78a000/i2c-bus at 40/pca9542 at 70/i2c at 0/pca9546 at 77/i2c at 0 has
> invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
> arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dtb: Warning
> (reg_format): "reg" property in
> /ahb/apb/i2c at 1e78a000/i2c-bus at 40/pca9542 at 70/i2c at 0/pca9546 at 77/i2c at 2 has
> invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
> arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dtb: Warning
> (reg_format): "reg" property in
> /ahb/apb/i2c at 1e78a000/i2c-bus at 40/pca9542 at 70/i2c at 1 has invalid length
> (4 bytes) (#address-cells == 2, #size-cells == 1)
> arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dtb: Warning
> (reg_format): "reg" property in
> /ahb/apb/i2c at 1e78a000/i2c-bus at 40/pca9542 at 70/i2c at 1/pca9546 at 77/i2c at 2 has
> invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
> arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dtb: Warning
> (reg_format): "reg" property in
> /ahb/apb/i2c at 1e78a000/i2c-bus at 340/pca9641 at 70/i2c-arb/tmp421 at 1d has
> invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
> arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dtb: Warning
> (reg_format): "reg" property in
> /ahb/apb/i2c at 1e78a000/i2c-bus at 340/pca9641 at 70/i2c-arb/adm1278 at 12 has
> invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
> arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dtb: Warning
> (reg_format): "reg" property in
> /ahb/apb/i2c at 1e78a000/i2c-bus at 340/pca9641 at 70/i2c-arb/eeprom at 50 has
> invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
> arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dtb: Warning
> (reg_format): "reg" property in
> /ahb/apb/i2c at 1e78a000/i2c-bus at 340/pca9641 at 70/i2c-arb/ds1100 at 58 has
> invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
> arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dtb: Warning
> (avoid_default_addr_size): Relying on default #address-cells value for
> /ahb/apb/i2c at 1e78a000/i2c-bus at 40/pca9542 at 70/i2c at 0
> arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dtb: Warning
> (avoid_default_addr_size): Relying on default #size-cells value for
> /ahb/apb/i2c at 1e78a000/i2c-bus at 40/pca9542 at 70/i2c at 0
> arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dtb: Warning
> (avoid_default_addr_size): Relying on default #address-cells value for
> /ahb/apb/i2c at 1e78a000/i2c-bus at 40/pca9542 at 70/i2c at 0/pca9546 at 77/i2c at 0
> arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dtb: Warning
> (avoid_default_addr_size): Relying on default #size-cells value for
> /ahb/apb/i2c at 1e78a000/i2c-bus at 40/pca9542 at 70/i2c at 0/pca9546 at 77/i2c at 0
> arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dtb: Warning
> (avoid_default_addr_size): Relying on default #address-cells value for
> /ahb/apb/i2c at 1e78a000/i2c-bus at 40/pca9542 at 70/i2c at 0/pca9546 at 77/i2c at 2
> arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dtb: Warning
> (avoid_default_addr_size): Relying on default #size-cells value for
> /ahb/apb/i2c at 1e78a000/i2c-bus at 40/pca9542 at 70/i2c at 0/pca9546 at 77/i2c at 2
> arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dtb: Warning
> (avoid_default_addr_size): Relying on default #address-cells value for
> /ahb/apb/i2c at 1e78a000/i2c-bus at 40/pca9542 at 70/i2c at 1
> arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dtb: Warning
> (avoid_default_addr_size): Relying on default #size-cells value for
> /ahb/apb/i2c at 1e78a000/i2c-bus at 40/pca9542 at 70/i2c at 1
> arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dtb: Warning
> (avoid_default_addr_size): Relying on default #address-cells value for
> /ahb/apb/i2c at 1e78a000/i2c-bus at 40/pca9542 at 70/i2c at 1/pca9546 at 77/i2c at 2
> arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dtb: Warning
> (avoid_default_addr_size): Relying on default #size-cells value for
> /ahb/apb/i2c at 1e78a000/i2c-bus at 40/pca9542 at 70/i2c at 1/pca9546 at 77/i2c at 2
> arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dtb: Warning
> (avoid_default_addr_size): Relying on default #address-cells value for
> /ahb/apb/i2c at 1e78a000/i2c-bus at 340/pca9641 at 70/i2c-arb/tmp421 at 1d
> arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dtb: Warning
> (avoid_default_addr_size): Relying on default #size-cells value for
> /ahb/apb/i2c at 1e78a000/i2c-bus at 340/pca9641 at 70/i2c-arb/tmp421 at 1d
> arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dtb: Warning
> (avoid_default_addr_size): Relying on default #address-cells value for
> /ahb/apb/i2c at 1e78a000/i2c-bus at 340/pca9641 at 70/i2c-arb/adm1278 at 12
> arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dtb: Warning
> (avoid_default_addr_size): Relying on default #size-cells value for
> /ahb/apb/i2c at 1e78a000/i2c-bus at 340/pca9641 at 70/i2c-arb/adm1278 at 12
> arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dtb: Warning
> (avoid_default_addr_size): Relying on default #address-cells value for
> /ahb/apb/i2c at 1e78a000/i2c-bus at 340/pca9641 at 70/i2c-arb/eeprom at 50
> arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dtb: Warning
> (avoid_default_addr_size): Relying on default #size-cells value for
> /ahb/apb/i2c at 1e78a000/i2c-bus at 340/pca9641 at 70/i2c-arb/eeprom at 50
> arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dtb: Warning
> (avoid_default_addr_size): Relying on default #address-cells value for
> /ahb/apb/i2c at 1e78a000/i2c-bus at 340/pca9641 at 70/i2c-arb/ds1100 at 58
> arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dtb: Warning
> (avoid_default_addr_size): Relying on default #size-cells value for
> /ahb/apb/i2c at 1e78a000/i2c-bus at 340/pca9641 at 70/i2c-arb/ds1100 at 58
>
I will remove the device and update the pca9641 drvier in future.
>>
>> When you send v5 you can add the Acked-by line from Andrew to your
>> commit message.
Got it
>>
>> Cheers,
>>
>> Joel


More information about the openbmc mailing list