Proprietary task references in commit logs

[Patrick Venture]

Alexander;

So, we've been in a similar boat, in that we have a Google-Bug-Id in
all our commits.  However, for openbmc we've been trimming them out.
I think part of the argument is to keep the commit message clean, or
if necessary file a corresponding bug in the openbmc bug track, and
then close that bug id.

Can you point the jira bug to the github bug track?

Patrick

On Tue, Feb 13, 2018 at 5:13 AM, Alexander Amelkin <a.amelkin at yadro.com> wrote:
> Hi all.
>
> Do you think it is acceptable to have a reference to a proprietary task ID
> in a commit log?
>
> We're using JIRA and would like to see related commits displayed in the
> corresponding issue. That requires putting the issue ID into the commit log,
> so the log would look something like this:
>
> ===========
>
> Fix some bug (less than 50 chars as usual)
>
> Long description goes here.
> Multiple lines, each less than 72 characters, as usual.
>
> Company Ref: KEY-1234
>
> Change-Id: I5e0f94d168a61b6d82214779aa6ebd9796dc37b2
> Signed-off-by: The Author <t.author at company.tld>
>
> ===========
>
> Any comments are welcome.
>