Feature request in phosphor-pid-control

Patrick Venture venture at google.com
Fri Aug 31 06:25:47 AEST 2018


On Thu, Aug 30, 2018 at 1:17 PM Patrick Venture <venture at google.com> wrote:
>
> On Thu, Jun 14, 2018 at 7:21 PM Lei YU <mine260309 at gmail.com> wrote:
> >
> > > So, this change really is just, "don't fail if you can't find the
> > > sensor during start-up, and keep trying until it shows up"
> > >
> > > Does that follow?
> >
> > Pretty much close.
> > More like "in any case, don't fail if you can't find the the sensor, and keep
> > trying".
> > Note this is applicable to sensors that are unavailable.
> >
> > For sensors that are expected to be treated as fault, it should trigger
> > failsafe, and this is discussed in Ed's mail.
> >
> > Putting it together, the feature request is splitted:
> > 1. For sensors without operation status, we can config them as optional, so
> >    they do not trigger failsafe;
> > 2. For sensors with operation status, do not trigger failsafe if it is
> >    unavailable; trigger failsafe if it is fault.
>
> Just bumping this back to the top of my list.  I don't know that I'll
> have to time to restructure the initialization of sensors until a few
> weeks from now.  However, I'm bumping this now because I'm doing some
> phosphor-pid-control work again and it's a good time to think about
> these features -- since I'm already cracking it open.

https://github.com/openbmc/phosphor-pid-control/issues/2


More information about the openbmc mailing list