[PATCH v2 1/2] dt-binding: i2c: npcm7xx: add binding for i2c controller
Rob Herring
robh at kernel.org
Fri Aug 10 08:41:16 AEST 2018
Hi, this is an automated email from Rob's (experimental) review bot. I
found a couple of common problems with your patch. Please see below.
On Tue, 7 Aug 2018 14:07:08 +0300, Tali Perry wrote:
> Nuvoton NPCM7XX I2C Controller
> NPCM7xx includes 16 I2C contollers. THis driver operates the controller.
> This module also includes a slave mode, which will be submitted later on.
>
> Any feedback would be appreciated.
>
> v2 -> v1:
> - run check patch in strict mode.
> - use linux crc.
> - define regs in constant offset without base.
> - remove debug prints.
> - no declerations for local functions.
>
> v1: initial version
>
> Signed-off-by: Tali Perry <tali.perry1 at gmail.com>
>
The preferred subject prefix is "dt-bindings: <binding dir>: ...".
> ---
> .../devicetree/bindings/i2c/i2c-npcm7xx.txt | 27 ++++++++++++++++++++++
> MAINTAINERS | 8 +++++++
> 2 files changed, 35 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/i2c/i2c-npcm7xx.txt
>
More information about the openbmc
mailing list